The fix need to be merged into wicket7 (and wicket6?) On Fri, Apr 7, 2017 at 5:33 PM, Tobias Soloschenko < [email protected]> wrote:
> Thanks a ton! > > kind regards > > Tobias > > > Am 07.04.2017 um 12:20 schrieb Martin Grigorov <[email protected]>: > > > > Hi Tobias, > > > > Maxim, Mikhail, Sebastien and Andrea already worked it out: > > https://github.com/openjson/openjson/issues/7 > > > > Martin Grigorov > > Wicket Training and Consulting > > https://twitter.com/mtgrigorov > > > > On Fri, Apr 7, 2017 at 11:05 AM, Tobias Soloschenko < > > [email protected]> wrote: > > > >> Hi all, > >> > >> I just don't have any time currently to take care about the JSON issue. > >> Can someone take over it? > >> > >> Thanks a lot for the investigation Sebastien! > >> > >> kind regards > >> > >> Tobias > >> > >>> Am 04.04.2017 um 11:12 schrieb Andrea Del Bene <[email protected]>: > >>> > >>> My bad, dont worry :) > >>> > >>>> On Tue, Apr 4, 2017 at 11:09 AM, Sebastien <[email protected]> wrote: > >>>> > >>>> Hi Andrea, > >>>> > >>>> Sorry if my comment was confusing. The code has to be fixed in wicket > >>>> itself as it ports the json implementation. > >>>> https://github.com/openjson/openjson/issues/7 is for wicket8 because > it > >>>> directly uses it. > >>>> > >>>> Best regards, > >>>> Sebastien. > >>>> > >>>> > >>>> On Tue, Apr 4, 2017 at 10:58 AM, Andrea Del Bene < > [email protected]> > >>>> wrote: > >>>> > >>>>> Ok, > >>>>> > >>>>> This vote has been cancelled. I'll re-roll the release when > >>>>> https://github.com/openjson/openjson/issues/7 will be closed and > >>>> released. > >>>>> > >>>>>> On Sun, Apr 2, 2017 at 6:13 PM, Sebastien <[email protected]> wrote: > >>>>>> > >>>>>> [x] No, don't release Apache Wicket 7.7.0 > >>>>>> > >>>>>> There is a regression with the new json integration: calling > >>>>>> JSONArray(Collection<?> copyFrom) with a list of Objects leads to > >>>> putting > >>>>>> nulls in the underlying list (JSONObject#wrap seems to not take > Object > >>>>> type > >>>>>> into account) > >>>>>> > >>>>> > >>>> > >> > -- WBR Maxim aka solomax
