Hi Maxim, The fact that some 3rd party code (WicketStuff Select2) needs to be changed to be able to use Wicket 6.27.0 says that there is a breaking change in a minor version of Wicket. So the fix should be in Wicket, not in the third party library!
Technically it is not an API break but change in behavior. So it is worse - it will pass the compilation step but break at runtime (if there are no tests!). My personal opinion is that we should either leave it as it is now and explain users that we had to break the API due to legal reasons, or just use the old JSON2 library as in 6.26.0. Since no one complained about the same change in Wicket 7.7.0 then maybe we can just leave it and add a note in the release announcement of 6.27.0. Martin Grigorov Wicket Training and Consulting https://twitter.com/mtgrigorov On Wed, Jun 14, 2017 at 7:11 AM, Maxim Solodovnik <[email protected]> wrote: > Should be fixed with > https://github.com/wicketstuff/core/commit/d4dfe8946db5c6c6a21c1bd4383ba5 > f86ba5eb4e > > On Wed, Jun 14, 2017 at 11:43 AM, Maxim Solodovnik <[email protected]> > wrote: > > > Hello All, > > > > I'm back, going to check select2 right now > > > > On Mon, Jun 5, 2017 at 8:13 PM, Andrea Del Bene <[email protected]> > > wrote: > > > >> This vote fails due to the following main issues: > >> > >> - page store is broken (WICKET-6387) > >> - JSON API break ( > >> http://mail-archives.apache.org/mod_mbox/wicket-dev/201705. > >> mbox/%3CCAMomwMq46Mn_5-fy%3Dn8kYd0zh__YVOPi75ujugOMTm50V > >> 2MN7g%40mail.gmail.com%3E > >> ) > >> > >> On Sat, Jun 3, 2017 at 12:30 PM, Sven Meier <[email protected]> wrote: > >> > >> > -1 page store is broken, see WICKET-6387 > >> > > >> > Regards > >> > Sven > >> > > >> > > >> > > >> > Am 28.05.2017 um 12:49 schrieb Andrea Del Bene: > >> > > >> >> This is a vote to release Apache Wicket 6.27.0 > >> >> > >> >> Please download the source distributions found in our staging area > >> >> linked below. > >> >> > >> >> I have included the signatures for both the source archives. This > vote > >> >> lasts for 72 hours minimum. > >> >> > >> >> [ ] Yes, release Apache Wicket 6.27.0 > >> >> [ ] No, don't release Apache Wicket 6.27.0, because ... > >> >> > >> >> Distributions, changelog, keys and signatures can be found at: > >> >> > >> >> https://dist.apache.org/repos/dist/dev/wicket/6.27.0 > >> >> > >> >> Staging repository: > >> >> > >> >> > >> >> https://repository.apache.org/content/repositories/orgapache > >> wicket-1093/ > >> >> > >> >> The binaries are available in the above link, as are a staging > >> >> repository for Maven. Typically the vote is on the source, but should > >> >> you find a problem with one of the binaries, please let me know, I > can > >> >> re-roll them some way or the other. > >> >> > >> >> Staging git repository data: > >> >> > >> >> Repository: [email protected]:bitstorm/wicket.git > >> >> Branch: build/wicket-6.27.0 > >> >> Release tag: rel/wicket-6.27.0 > >> >> > >> >> > >> >> ============================================================ > >> ============ > >> >> > >> >> The signatures for the source release artefacts: > >> >> > >> >> > >> >> Signature for apache-wicket-6.27.0.zip: > >> >> > >> >> -----BEGIN PGP SIGNATURE----- > >> >> Version: GnuPG v1 > >> >> > >> >> iQIcBAABAgAGBQJZKqodAAoJEAzCjx+CMhBVU2MP/2UCfeFMDyggvsPJp5i7p0oF > >> >> ekpLkpHDw+0ytxoRQIzyhcPnARjcOjgDHZw/F52ESvszlVgXlb0MuAerg1mmYCfL > >> >> lLba1L4O70zx/eWBirOd8A6I2GETQwEmTvekZBMdewykWHSsoOLf3LCQpw1evcFI > >> >> KV6DSoe/V5kOi29aaXxpNjYKEShTLn0qiMorryQ+V+DR+wQuKuXDlTbTlrljdBb0 > >> >> F6FX3jDXkCksWR7DjTN+7D+pfASkuwGusL5MVNDzpC3/Zr1F88k48Zva4zEFDvI0 > >> >> QnV8Zhc85w88MInouYWqDj9Ou+ysUipdl2FEl30uIyxb7eeUrVdABz9JZKHZLFQt > >> >> rkZrpYYV34LOREfPbvNB+Jl7LlH+zie2fXZA9IecV7RfAiuZZC/I1gNUv6F+Deg3 > >> >> z/DQY5Wur3NIsGDKaNf7YLDgoii6ZZP/YAmof6jNAz6ha5WkFNy/PQDbEfIi9Wey > >> >> Lxu0eEAYZNVgEkLV2jPbSbGs/RlZHOdmGDHpT8BKSxZElWJ7GQweiQ5EEN8uayxo > >> >> stjg51dYUccNqcbw+bW0d6cIKJ+iPKi9RN5RhAJKCNJeYwv6JvtoUIqbJdV+IwYu > >> >> FbymO6i+oz1NNCWh9r9lFqHM+feZ4NsDpbmv1rEBt04fHopp+jakcsx8WjCA3lVW > >> >> n53inWtrha6M6SYJZ04i > >> >> =bONO > >> >> -----END PGP SIGNATURE----- > >> >> > >> >> Signature for apache-wicket-6.27.0.tar.gz: > >> >> > >> >> -----BEGIN PGP SIGNATURE----- > >> >> Version: GnuPG v1 > >> >> > >> >> iQIcBAABAgAGBQJZKqodAAoJEAzCjx+CMhBV9hMP/Rkzdt6hII+y7nOh5D/f5dAH > >> >> dYV88Lbs9PRS73HcvZzIL5IjklACgu3f67DpNdehEbANgwwluCh5FaWAmj9ZgGNC > >> >> xQPQLYjlzIReJUPi3reTcJIgArP3fgp563Yb8cheKd1W09YzTd61Fuy9uHUBhCT1 > >> >> yr5yqJmmbWc3TyOKy6aYcN+As9foLN6z66Acru3w03++1EtNh1ol+rTTPhYTfSAR > >> >> 9Jt8lwLVSCPE/o8G7CR1HsdWd+Qtw189pnfwHSA0cftzu2APer56cini3D3RhW7s > >> >> AVRqN7nn8nAEJZwedXSZ7DG8zRH3pWJ1x5MWREFnDj2zcTPtiwhYDry2zmT2MmCr > >> >> zD/VngEsfkRsIDEAFLyA0UznxUrZyM5Y1QITN7uJqRMkU52/DSQCwLgfmgpRzNBC > >> >> cIvM2pPPkWVHO2v55Ygol9MMdtGKKwxGnNgrhxMRbU5HdaaJiSBehp/LKg/YawBB > >> >> 3HLXw+IaMQ+A39rNG0BsBhJu0GhmzavmhK1AX6r1Z+GYK9Xz/Fc5VJvFLPjRzqJH > >> >> 3a/afSc5uzjQAkUWSqVEZ5S+fgH+mMQ6xa1e4SfT8dXZd625dbPj7uQWa922j1nz > >> >> 7LQ28kLcLGRTLFed0SHee8ZbOE3g/X7A18GuwQAdo3No/EPwwjNR/B3xk7i+2sBm > >> >> npzDCtBX6oVxHy2FbRuu > >> >> =1vlI > >> >> -----END PGP SIGNATURE----- > >> >> > >> >> ============================================================ > >> ============ > >> >> > >> >> CHANGELOG for 6.27.0: > >> >> > >> >> ** Bug > >> >> > >> >> * [WICKET-6165] - Inconsistent behavior of Markupstream.hasMore > vs. > >> >> MarkupStream.next. > >> >> * [WICKET-6314] - 7.6 release references 7.5-SNAPSHOT poms > >> >> * [WICKET-6316] - Wicket tester encodes page id for stateless > links > >> >> in stateless pages > >> >> * [WICKET-6340] - The Ajax reponse of an AjaxSubmitButton creates > >> >> invalid XHTML markup for multipart forms > >> >> * [WICKET-6356] - Clustering failover not working on Tomcat > >> >> * [WICKET-6362] - HeaderItems with different PageParameters are > >> >> treated as identical > >> >> > >> >> ** Improvement > >> >> > >> >> * [WICKET-6212] - CheckChoice / add a getAdditionalAttributes() > >> also > >> >> for <label>-tag > >> >> * [WICKET-6307] - SubmitLink does not work in Chrome "ff.onsubmit > >> is > >> >> not a function" > >> >> * [WICKET-6323] - Allow ResourceBundles to use the defer > attribute > >> >> * [WICKET-6351] - Form.anyFormComponentError performance > >> degradation > >> >> * [WICKET-6364] - The autogenerated input field when a form has a > >> >> default button should not gain the focus when navigating with tab > >> >> > >> >> ** Task > >> >> > >> >> * [WICKET-6287] - Switch from json.org to open-json > >> >> > >> > > >> > > >> > > > > > > > > -- > > WBR > > Maxim aka solomax > > > > > > -- > WBR > Maxim aka solomax >
