Hi Andreas, Am Donnerstag, 19. Juni 2003 21:08 schrieb Andreas Fink: > On Jeudi, juin 19, 2003, at 08:33 Uhr, Alexander Malysh wrote: > > Hi, > > > > i found a small memleak after it ... > > Attached you can find corrected version of this patch. > > I can say, mysql and internal where tested and works on our production > > systems > > without any problems. libsdb is not tested yet, but should work, > > because i > > have not changed any calls to the library itself. So please people, > > who use > > libsdb, test it! > > > > What happens is pretty simple ;) > > > > 1. if dlr_init calls then here storage will be initilialized return > > pointer to > > operations struct. pls consult dlr_p.h for possible operations on the > > storage. > > 2. If dlr_find calls then core dlr do following: > > call storage get function > > create new dlr message > > check if this end status of message (e.g. delivered or undelivered) > > and then > > delete the message by calling of remove storage funct. if end state not > > reached then call storage update status entry funct. (its optional, > > that > > means, if storage define this funct. it will be called otherwise not) > > 3. dlr_status just call storage status funct. > > I looked at the patch but I don't understand what the "cleanup" purpose > was.. > can you explain?
sure... 1) make easier to add new dlr storage types to kannel without touching a dlr-core code. With old dlr handling you must to go over all storage types in order to add your's. Now u must simple implement clear defined operations for your storage type without touching any line in dlr core handling. Yet not fully true, due to lack of modules API, now you must add your new storage type (equal to SMSCConn) to dlr_init function. 2) not equal creating of dlrs for different storage types. In old dlr code we have for example in internal storage reversed source and destination addr in dlr msg but not in mysql. 3) that had grown with the time and looks bad ;) this is the same as for SMSCConn... why it was rewriten? a: in order to get things clearer and easier to handle... > > Andreas Fink > Global Networks Switzerland AG > > ------------------------------------------------------------------ > Tel: +41-61-6666333 Fax: +41-61-6666334 Mobile: +41-79-2457333 > Global Networks, Inc. Clarastrasse 3, 4058 Basel, Switzerland > Web: http://www.global-networks.ch/ [EMAIL PROTECTED] > ------------------------------------------------------------------ -- Best regards / Mit besten Grüßen aus Köln Dipl.-Ing. Alexander Malysh ___________________________________ Centrium GmbH Ehrenstrasse 2 50672 Köln Fon: +49 (0221) 277 49 240 Fax: +49 (0221) 277 49 109 email: a.malysh at centrium.de web: http://www.centrium.de msn: olek2002 at hotmail.com ___________________________________________ Please avoid sending me Word or PowerPoint attachments. See http://www.fsf.org/philosophy/no-word-attachments.html
