hi again, yep, that's a good idea to remember all us on our todo list ;) Slava, why not just modify your patch in order to not use "yet another thread"? as I can see, you have done the most work for it, simple kill the thread and put function call to another appropriate place should do the trick? that will have also advantages for you, no need to patch kannel ;)
On Monday 24 November 2003 15:53, Vjacheslav Chekushin wrote: > Hi, Alexander, > > I agree with you about "yet another thread". > But sockets are limited resources too. > Now sockets from conn_pool (client part of http library) > _never_ released after use (see conn_pool_put function). > > David patch cleans sockets only for server part of http library, and it is > good, but what about sockets at client part? > > From http.c: > /* XXX re-implement socket pools, with idle connection killing to save > sockets */ - it is about client part. > > This means that either with new thread or without, but this part must be > patched too. > > I post my patch with goal to remind about the problem. > It is not problem for me to patch sources on my side by myself ;) > > And about David's patch: > in function pointer_to_octstr() > > + char *tmp = (char *) gw_malloc(sizeof(char) * 255); > + sprintf(tmp, "%ld", p); > + tmp_oct = octstr_create(tmp); > + gw_free(tmp); > > can be changed to use octstr_format() > > Alexander Malysh wrote: > > Hi Slava, > > > > I would vote -1 for your patch. I see no need to start "yet another > > thread" only to watch timedout connections (threads are limited > > resources). David's patch (though only for http-server part) avoid it > > gracefully... > > > > David your patch has one problem (what I can see right now): > > please add cleanup for appropriate clients into port_remove function; > > otherwise callback function will be called for those clients, wich call > > port_put function then and we have panic, because port just doesn't > > exists in the dictionary anymore. > > > > On Monday 24 November 2003 13:52, Vjacheslav Chekushin wrote: -- Best regards / Mit besten Grüßen aus Düsseldorf Dipl.-Ing. Alexander Malysh ___________________________________________ Centrium GmbH Vogelsanger Weg 80 40470 Düsseldorf Fon: +49 (0211) 74 84 51 80 Fax: +49 (0211) 277 49 109 email: [EMAIL PROTECTED] web: www.centrium.de msn: [EMAIL PROTECTED] icq: 98063111 ___________________________________________ Please avoid sending me Word, Excel or PowerPoint attachments. See http://www.fsf.org/philosophy/no-word-attachments.html
