Hi Alex,
Looks good. Some typos:
Userguide:
string <-> stringr
...this TLV valid <-> ...this TLV is valid(twice).
gw/smsc/smpp_pdu.c: 69
+#define DEFAULT_SMSC_ID "def;ault"
Is this right? Did you mean "default"?
BR,
Nikos
----- Original Message -----
From: "Alexander Malysh" <amal...@kannel.org>
To: "Development mailing list" <devel@kannel.org>
Sent: Wednesday, September 02, 2009 12:58 AM
Subject: [PATCH] add support of smsc-id for smpp-tlv group
Hi list,
seems I was to lazy and didn't implement smsc-id support for smpp-tlv
group :)
Attached is patch that corrects this.
The rule to look for smpp-tlv group is as follows:
1) by start we put smpp-tlv to smsc-id specific Dict if none given to
default smsc-id.
smsc-id may be a list splitted by ;
2) then if we need tlv by name/tag we look first for specific smsc-id
Dict and if tlv
not found for default smsc-id
Comments are welcome.
Thanks,
Alexander Malysh
--------------------------------------------------------------------------------
