There's a couple things about this spec file which are quite strange.
Firstly the %autosetup directory parameter is not the top level
directory:
%prep
%autosetup -n firefox-%{version}/js/src -N
(https://src.fedoraproject.org/rpms/mozjs102/blob/rawhide/f/mozjs102.spec#_108)
This means if you re-run 'fedpkg local' (or mock, I guess, without a
cleaning step) then it doesn't actually delete all the old files, only
the ones under js/src, and that causes build failures later on when it
tries to recreate directories that already exist:
+ mkdir third_party/python/looseversion
mkdir: cannot create directory ‘third_party/python/looseversion’: File exists
(https://src.fedoraproject.org/rpms/mozjs102/blob/rawhide/f/mozjs102.spec#_121)
Secondly the mock /builddir path is hard-coded in a few places, eg:
export AC_MACRODIR=/builddir/build/BUILD/firefox-%{version}/build/autoconf/
sh ../../build/autoconf/autoconf.sh
--localdir=/builddir/build/BUILD/firefox-%{version}/js/src configure.in >
configure
(https://src.fedoraproject.org/rpms/mozjs102/blob/rawhide/f/mozjs102.spec#_150)
This breaks local builds with 'fedpkg build' or rpmbuild entirely.
Are these bugs? Is there a reason to do things this way?
Rich.
--
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
Fedora Windows cross-compiler. Compile Windows programs, test, and
build Windows installers. Over 100 libraries supported.
http://fedoraproject.org/wiki/MinGW
--
_______________________________________________
devel mailing list -- devel@lists.fedoraproject.org
To unsubscribe send an email to devel-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org
Do not reply to spam, report it:
https://pagure.io/fedora-infrastructure/new_issue
