On Thu, Feb 19, 2004 at 11:20:50PM +0100, Roland Mainz wrote:
>David Dawes wrote:
>> >David Dawes wrote:
>> >> CVSROOT:        /home/x-cvs
>> >> Module name:    xc
>> >> Changes by:     [EMAIL PROTECTED]       04/02/11 13:11:26
>> >>
>> >> Log message:
>> >>    799. Some more font path checks.
>> >>
>> >> Modified files:
>> >>       xc/lib/font/fontfile/:
>> >>         dirfile.c encparse.c fontfile.c
>> >>       xc/programs/Xserver/hw/xfree86/:
>> >>         CHANGELOG
>> >>
>> >>   Revision      Changes    Path
>> >>   3.18          +17 -1     xc/lib/font/fontfile/dirfile.c
>> >>   1.20          +7 -2      xc/lib/font/fontfile/encparse.c
>> >>   3.22          +30 -11    xc/lib/font/fontfile/fontfile.c
>> >>   3.3139        +2 -1      xc/programs/Xserver/hw/xfree86/CHANGELOG
>> >
>> >David:
>> >Somehow these changes broke Xprt's handing of printer builtin fonts
>> >(e.g. font paths prefixed with "PRINTER:" which are "enabled"
>> >dynamically on per-model-config basis).
>> 
>> Can you isolate which of the changes causes the problem by adding them
>> in one at a time?
>
>Yes, it seems that my original observation was wrong. Not the
>printer-builtin fonts are affected but parts of the font path are
>dropped.
>The following statement in xc/lib/font/fontfile/dirfile.c causes the
>failure:
>(from
>http://xprint.freedesktop.org/cgi-bin/bugzilla/attachment.cgi?id=95&action=view)
>-- snip --
>+       }
>+       if (!found_font) {
>+           FontFileFreeDir (dir);
>+           fclose(file);
>+           return BadFontPath;
>        }
>-- snip --
>It seems that the change now makes it mandatory that the Xserver allows
>to drop invalid font path elements... ;-/

I guess that's this change:

  70. Changed behavior of fontfile: don't drop the entire directory if some
      fonts cannot be rendered (Egbert Eich).

What exactly is it doing that breaks the printer fonts?

David
_______________________________________________
Devel mailing list
[EMAIL PROTECTED]
http://XFree86.Org/mailman/listinfo/devel

Reply via email to