On Sun, Jan 08, 2012 at 03:32:21PM +0200, Gilad Ben-Yossef wrote:
> on_each_cpu always returns a hard coded return code of zero.
>
> Removing all tests based on this return value saves run time
> cycles for compares and code bloat for branches.
>
> Signed-off-by: Gilad Ben-Yossef <gi...@benyossef.com>
> Acked-by: Peter Zijlstra <a.p.zijls...@chello.nl>
> Reviewed-by: Michal Nazarewicz <min...@mina86.com>
> CC: Will Deacon <will.dea...@arm.com>
> CC: Peter Zijlstra <a.p.zijls...@chello.nl>
> CC: Paul Mackerras <pau...@samba.org>
> CC: Ingo Molnar <mi...@elte.hu>
> CC: Arnaldo Carvalho de Melo <a...@ghostprotocols.net>
> CC: Russell King <li...@arm.linux.org.uk>
Reviewed-by: Russell King <rmk+ker...@arm.linux.org.uk>
> CC: Grant Likely <grant.lik...@secretlab.ca>
> CC: Rob Herring <rob.herr...@calxeda.com>
> CC: linux-arm-ker...@lists.infradead.org
> CC: devicetree-discuss@lists.ozlabs.org
> ---
> arch/arm/kernel/perf_event.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/arch/arm/kernel/perf_event.c b/arch/arm/kernel/perf_event.c
> index 5bb91bf..6e9acb7 100644
> --- a/arch/arm/kernel/perf_event.c
> +++ b/arch/arm/kernel/perf_event.c
> @@ -616,7 +616,7 @@ static int __init
> cpu_pmu_reset(void)
> {
> if (cpu_pmu && cpu_pmu->reset)
> - return on_each_cpu(cpu_pmu->reset, NULL, 1);
> + on_each_cpu(cpu_pmu->reset, NULL, 1);
There's not much to review here...
Thanks.
> return 0;
> }
> arch_initcall(cpu_pmu_reset);
> --
> 1.7.0.4
>
_______________________________________________
devicetree-discuss mailing list
devicetree-discuss@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/devicetree-discuss
