[RFC PATCH v2 12/15] cpufreq: arm_big_little: remove device tree parsing for cpu nodes

[Sudeep . KarkadaNagesha]

From: Sudeep KarkadaNagesha <sudeep.karkadanage...@arm.com>

Now that the cpu device registration initialises the of_node(if available)
appropriately for all the cpus, parsing here is redundant.

This patch removes all DT parsing and uses cpu->of_node instead.

Acked-by: Viresh Kumar <viresh.ku...@linaro.org>
Signed-off-by: Sudeep KarkadaNagesha <sudeep.karkadanage...@arm.com>
---
 drivers/cpufreq/arm_big_little_dt.c | 39 ++++++++++++++++---------------------
 1 file changed, 17 insertions(+), 22 deletions(-)

diff --git a/drivers/cpufreq/arm_big_little_dt.c 
b/drivers/cpufreq/arm_big_little_dt.c
index fd9e3ea..d2648d1 100644
--- a/drivers/cpufreq/arm_big_little_dt.c
+++ b/drivers/cpufreq/arm_big_little_dt.c
@@ -34,27 +34,19 @@
 /* get cpu node with valid operating-points */
 static struct device_node *get_cpu_node_with_valid_op(int cpu)
 {
-       struct device_node *np = NULL, *parent;
-       int count = 0;
+       struct device *cpu_dev = get_cpu_device(cpu);
+       struct device_node *np;
 
-       parent = of_find_node_by_path("/cpus");
-       if (!parent) {
-               pr_err("failed to find OF /cpus\n");
+       if (!cpu_dev) {
+               pr_err("failed to get cpu device\n");
                return NULL;
        }
-
-       for_each_child_of_node(parent, np) {
-               if (count++ != cpu)
-                       continue;
-               if (!of_get_property(np, "operating-points", NULL)) {
-                       of_node_put(np);
-                       np = NULL;
-               }
-
-               break;
+       np = of_node_get(cpu_dev->of_node);
+       if (!of_get_property(np, "operating-points", NULL)) {
+               of_node_put(np);
+               np = NULL;
        }
 
-       of_node_put(parent);
        return np;
 }
 
@@ -63,11 +55,12 @@ static int dt_init_opp_table(struct device *cpu_dev)
        struct device_node *np;
        int ret;
 
-       np = get_cpu_node_with_valid_op(cpu_dev->id);
-       if (!np)
-               return -ENODATA;
+       np = of_node_get(cpu_dev->of_node);
+       if (!np) {
+               pr_err("failed to find cpu%d node\n", cpu_dev->id);
+               return -ENOENT;
+       }
 
-       cpu_dev->of_node = np;
        ret = of_init_opp_table(cpu_dev);
        of_node_put(np);
 
@@ -79,9 +72,11 @@ static int dt_get_transition_latency(struct device *cpu_dev)
        struct device_node *np;
        u32 transition_latency = CPUFREQ_ETERNAL;
 
-       np = get_cpu_node_with_valid_op(cpu_dev->id);
-       if (!np)
+       np = of_node_get(cpu_dev->of_node);
+       if (!np) {
+               pr_info("Failed to find cpu node. Use CPUFREQ_ETERNAL 
transition latency\n");
                return CPUFREQ_ETERNAL;
+       }
 
        of_property_read_u32(np, "clock-latency", &transition_latency);
        of_node_put(np);
-- 
1.8.1.2


_______________________________________________
devicetree-discuss mailing list
devicetree-discuss@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/devicetree-discuss