[ 
http://jira.codehaus.org/browse/DISPL-646?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=204537#action_204537
 ] 

Michael Osipov commented on DISPL-646:
--------------------------------------

Jeff,

I must admit, yes the POM is misconfigured. slf4j-log4j binding is absolutely 
useless. But I still do disagree, slf4j itself is not unnecessary. It 
completely replaces JCL because it's old, not performant as SFL4J and most 
people moved to SFL4J anyway.

At least in my projects I use SFL4J exclusively. I excluded the false 
transitive deps.

> POM config exposes unneeded dependencies to client apps
> -------------------------------------------------------
>
>                 Key: DISPL-646
>                 URL: http://jira.codehaus.org/browse/DISPL-646
>             Project: DisplayTag
>          Issue Type: Bug
>          Components: Build/distribution
>    Affects Versions: 1.2
>            Reporter: Jeff Jensen
>
> DisplayTag transitive dependencies cause erroneous configuration on client 
> projects.  Specifically, DisplayTag should depend on only slf4j-api in the 
> compile scope, resulting in exposing only that required dependency to client 
> apps, and the slf4j-log4j12 and jcl104-over-slf4j dependencies should be 
> removed (or changed to test scope if wanted for local testing).
> slf4j-api would be a new direct dependency to DisplayTag.  It currently is 
> transitively brought in through the slf4j-log4j12 direct dependency.
> I noticed this because, after just adding DisplayTag to my web app, SLF4J 
> gave error messages on multiple SLF4J bindings on app startup - one binding 
> is correctly from my POM/app config (found in logback-classic) and the other 
> is erroneously exposed transitively from DisplayTag's dependency 
> slf4j-log4j12.
> See http://www.slf4j.org/codes.html#multiple_bindings for the SLF4J error.
> The root cause is the DisplayTag POM exposing slf4j-log4j12 and 
> jcl104-over-slf4j dependencies.  Client apps do not need those specifically, 
> e.g. slf4j-log4j12 is not needed with Logback.
> This dependency configuration approach also forces client apps to have log4j 
> on the classpath transitively from slf4j-log4j12.  We do not use Log4J.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

------------------------------------------------------------------------------
This SF.Net email is sponsored by the Verizon Developer Community
Take advantage of Verizon's best-in-class app development support
A streamlined, 14 day to market process makes app distribution fast and easy
Join now and get one step closer to millions of Verizon customers
http://p.sf.net/sfu/verizon-dev2dev 
_______________________________________________
displaytag-devel mailing list
displaytag-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/displaytag-devel

Reply via email to