> Sorry Matt for the confusion, but let me clarify a couple things: > > 1. When you say "patch", do you mean the diff between the CVS file and > the patched files I created...or do you mean the complete > patched files?
You should be able to create a patch file that contains the diff between the two files. If you're on Windows, TortoiseCVS makes this very easy (tortoisecvs.org). You will need to checkout the source from CVS to create a patch for it. > > 2. When you say "upload", do you mean paste the patched files > (either diff or complete patched files) into the comments > window, because I don't see a way to "upload" or "attach" > files on this screen. > If there is a way attached or upload a file, then please > enlighten me. At the bottom of the screen, there's a form field with a button named "browse" - this can be used to select a file from your hard drive for uploading. HTH, Matt > > robert > > > -----Original Message----- > > From: [EMAIL PROTECTED] > > [mailto:[EMAIL PROTECTED] > Behalf Of Matt > > Raible > > Sent: Friday, January 23, 2004 8:07 AM > > To: [EMAIL PROTECTED] > > Subject: RE: [displaytag-user] Bug #840734 (Doesn't handle multiple > > form fields of the same name) > > > > > > I went to fix this and noticed there is no patch. To > submit a patch, > > go > > to: > > > > http://tinyurl.com/2x7uh > > > > And upload it at the bottom of the screen. > > > > HTH, > > > > Matt > > > > > -----Original Message----- > > > From: [EMAIL PROTECTED] > > > [mailto:[EMAIL PROTECTED] On Behalf Of > > > Robert Taylor > > > Sent: Thursday, January 22, 2004 8:12 AM > > > To: [EMAIL PROTECTED] > > > Subject: RE: [displaytag-user] Bug #840734 (Doesn't > handle multiple > > > form fields of the same name) > > > > > > > > > Thanks Matt, as you said, since it works for me, I'm in no real > > > hurry. The only reason I resent the message is because I > figured if > > > development had one less bug to fix, they could move on to more > > > important issues. > > > > > > robert > > > > > > > -----Original Message----- > > > > From: [EMAIL PROTECTED] > > > > [mailto:[EMAIL PROTECTED] > > > Behalf Of Matt > > > > Raible > > > > Sent: Thursday, January 22, 2004 9:37 AM > > > > To: [EMAIL PROTECTED] > > > > Cc: [EMAIL PROTECTED] > > > > Subject: RE: [displaytag-user] Bug #840734 (Doesn't handle > > > > multiple form fields of the same name) > > > > > > > > > > > > More than likely, the reason you haven't got a response > is because > > > > developers are busy, and since they don't experience this > > > problem on > > > > their projects, they have no motivation to fix it. At > > > least, that's > > > > my reason. ;-) > > > > > > > > I *do believe* it will be fixed before 1.0 is released, so > > > if it works > > > > on your project, I wouldn't worry about it. I've cc'd the > > > developers > > > > list for you. > > > > > > > > Matt > > > > > > > > > -----Original Message----- > > > > > From: [EMAIL PROTECTED] > > > > > [mailto:[EMAIL PROTECTED] > On Behalf > > > > > Of Robert Taylor > > > > > Sent: Thursday, January 22, 2004 7:12 AM > > > > > To: [EMAIL PROTECTED] > > > > > Subject: RE: [displaytag-user] Bug #840734 (Doesn't handle > > > > > multiple form fields of the same name) > > > > > > > > > > > > > > > I never did get a response from this. Should I post to the > > > > > developers list? > > > > > > > > > > robert > > > > > > > > > > > > > > > -------------------------------------------------------------- > > > > > -------------- > > > > > ---------- > > > > > SF doesn't allow file attachments on Bugs (or atleast I don't > > > > > see how to attach a file) but it does on RFE's. > > > > > > > > > > The patch I originally created was applied against version > > > > > 1.0b2. Since then I checked out the displaytag2 module ( I > > > > > assume that's the latest module) and applied the > patch against > > > > > that code. For testing, I ran it against some of my > code and the > > > > > patch seems to work as expected (handles multiple > form fields of > > > > > the same name). > > > > > > > > > > I followed Brad Smiths advice and reviewed the documentation > > > > > here: > > > > > https://sourceforge.net/docman/display_doc.php?docid=14033&gro > > > > > up_id=1#comman > > > > > ddiff > > > > > > > > > > I've executed the diff command and piped them to text > files. I > > > > > still don't see how to attach them as files to the bug. > > > > > > > > > > Should I just cut and paste the diff into the comments window? > > > > > > > > > > robert > > > > > > > > > > > -----Original Message----- > > > > > > From: [EMAIL PROTECTED] > > > > > > [mailto:[EMAIL PROTECTED] > > > > > Behalf Of Matt > > > > > > Raible > > > > > > Sent: Saturday, January 10, 2004 6:27 PM > > > > > > To: [EMAIL PROTECTED] > > > > > > Subject: Re: [displaytag-user] Bug #840734 (Doesn't handle > > > > > > multiple form fields of the same name) > > > > > > > > > > > > > > > > > > Once you're created the patch, just attach it to the bug on > > > > > SF. This > > > > > > should be possible, if not then e-mail it as an > > > attachment to this > > > > > > mailing list. The mailing list should be a last resort > > > since it's > > > > > > likely to get lost there. > > > > > > > > > > > > Matt > > > > > > > > > > > > On Jan 10, 2004, at 2:33 PM, Robert Taylor wrote: > > > > > > > > > > > > > Okay, I guess I need some help on this. You've implied > > > > > that I need > > > > > > > to access files via CVS. > > > > > > > I read over the CVS documetation so I understand how > > > to access > > > > > > > the repository. What I don't understand is how to get you > > > > > > > the patch. The docs say I have to be a > > > > > developer to > > > > > > > commit > > > > > > > to the repository but I'm sure you (or any other project > > > > > admin) don't > > > > > > > make > > > > > > > everyone a developer who has a bug patch. > > > > > > > > > > > > > > So, what's the best way to go about this. Sorry > for being so > > > > > > > ignorant. > > > > > > > > > > > > > > robert > > > > > > > > > > > > > >> -----Original Message----- > > > > > > >> From: [EMAIL PROTECTED] > > > > > > >> > > > [mailto:[EMAIL PROTECTED] Behalf > > > > > > >> Of > > > > > > >> Matt Raible > > > > > > >> Sent: Wednesday, January 07, 2004 10:40 AM > > > > > > >> To: [EMAIL PROTECTED] > > > > > > >> Subject: Re: [displaytag-user] Bug #840734 (Doesn't > > > > > handle multiple > > > > > > >> form fields of the same name) > > > > > > >> > > > > > > >> > > > > > > >> Submitting a patch is the best way to get it added. > > > > > > >> TortoiseCVS makes making patches easy on > windows. If you > > > > > > >> need > > > help on this, > > > > > > >> please let me know. > > > > > > >> > > > > > > >> Matt > > > > > > >> > > > > > > >> > > > > > > >> > > > > > > >> On Jan 7, 2004, at 7:32 AM, Robert Taylor wrote: > > > > > > >> > > > > > > >>> I've fixed bug #840734 (Doesn't handle multiple form > > > > > fields of the > > > > > > >>> same name). > > > > > > >>> How do I go about adding the fix to the code base? > > > > > > >>> > > > > > > >>> robert > > > > > > >>> > > > > > > >>> > > > > > > >>> > > > > > > >>> ------------------------------------------------------- > > > > > > >>> This SF.net email is sponsored by: IBM Linux Tutorials. > > > > > Become an > > > > > > >>> expert in LINUX or just sharpen your skills. > Sign up for > > > > > > >>> IBM's Free Linux Tutorials. Learn everything from the > > > > > > >>> bash > > > > > shell to sys > > > > > > >>> admin. > > > > > > >>> Click now! > > > > > http://ads.osdn.com/?ad_id=1278&alloc_id=3371&op=click > > > > > > >>> _______________________________________________ > > > > > > >>> displaytag-user mailing list > > > > > > >>> [EMAIL PROTECTED] > > > > > > >>> > https://lists.sourceforge.net/lists/listinfo/displaytag-us > > > > > > >>> er > > > > > > >> > > > > > > >> > > > > > > >> > > > > > > >> ------------------------------------------------------- > > > > > > >> This SF.net email is sponsored by: Perforce > > > Software. Perforce > > > > > > >> is the Fast Software Configuration Management > > > > > System offering > > > > > > >> advanced branching capabilities and atomic changes on > > > > > 50+ platforms. > > > > > > >> Free Eval! http://www.perforce.com/perforce/loadprog.html > > > > > > >> _______________________________________________ > > > > > > >> displaytag-user mailing list > > > > > > >> [EMAIL PROTECTED] > > > > > > >> > https://lists.sourceforge.net/lists/listinfo/displaytag-use > > > > > > >> r > > > > > > >> > > > > > > > > > > > > > > > > > > > > > > > > > > > > ------------------------------------------------------- > > > > > > > This SF.net email is sponsored by: Perforce Software. > > > Perforce > > > > > > > is the Fast Software Configuration Management > > > > > System offering > > > > > > > advanced branching capabilities and atomic changes on 50+ > > > > > platforms. > > > > > > > Free Eval! http://www.perforce.com/perforce/loadprog.html > > > > > > > _______________________________________________ > > > > > > > displaytag-user mailing list > > > > > > > [EMAIL PROTECTED] > > > > > > > > https://lists.sourceforge.net/lists/listinfo/displaytag-user > > > > > > > > > > > > > > > > > > > > > > > > ------------------------------------------------------- > > > > > > This SF.net email is sponsored by: Perforce Software. > > > Perforce is > > > > > > the Fast Software Configuration Management > > > > > System offering > > > > > > advanced branching capabilities and atomic changes on 50+ > > > > > > platforms. Free Eval! > > > > > > http://www.perforce.com/perforce/loadprog.html > > > > > > _______________________________________________ > > > > > > displaytag-user mailing list > > > > > > [EMAIL PROTECTED] > > > > > > https://lists.sourceforge.net/lists/listinfo/displaytag-user > > > > > > > > > > > > > > > > > > > > > > > > > > ------------------------------------------------------- > > > > > The SF.Net email is sponsored by EclipseCon 2004 Premiere > > > > > Conference on Open Tools Development and Integration See the > > > > > breadth of Eclipse activity. February 3-5 in Anaheim, CA. > > > > > http://www.eclipsecon.org/osdn > > > > > _______________________________________________ > > > > > displaytag-user mailing list > > > > > [EMAIL PROTECTED] > > > > > https://lists.sourceforge.net/lists/listinfo/displaytag-user > > > > > > > > > > > > > > > > > > > > > ------------------------------------------------------- > > > > The SF.Net email is sponsored by EclipseCon 2004 > > > > Premiere Conference on Open Tools Development and > > > Integration See the > > > > breadth of Eclipse activity. February 3-5 in Anaheim, CA. > > > > http://www.eclipsecon.org/osdn > > > > _______________________________________________ > > > > displaytag-user mailing list > [EMAIL PROTECTED] > > > > https://lists.sourceforge.net/lists/listinfo/displaytag-user > > > > > > > > > > > > > ------------------------------------------------------- > > > The SF.Net email is sponsored by EclipseCon 2004 > > > Premiere Conference on Open Tools Development and Integration See > > > the breadth of Eclipse activity. February 3-5 in Anaheim, CA. > > > http://www.eclipsecon.org/osdn > > > _______________________________________________ > > > displaytag-user mailing list [EMAIL PROTECTED] > > > https://lists.sourceforge.net/lists/listinfo/displaytag-user > > > > > > > > > > > ------------------------------------------------------- > > The SF.Net email is sponsored by EclipseCon 2004 > > Premiere Conference on Open Tools Development and > Integration See the > > breadth of Eclipse activity. February 3-5 in Anaheim, CA. > > http://www.eclipsecon.org/osdn > > _______________________________________________ > > displaytag-user mailing list [EMAIL PROTECTED] > > https://lists.sourceforge.net/lists/listinfo/displaytag-user > > > > > > ------------------------------------------------------- > The SF.Net email is sponsored by EclipseCon 2004 > Premiere Conference on Open Tools Development and Integration > See the breadth of Eclipse activity. February 3-5 in Anaheim, > CA. http://www.eclipsecon.org/osdn > _______________________________________________ > displaytag-user mailing list [EMAIL PROTECTED] > https://lists.sourceforge.net/lists/listinfo/displaytag-user > ------------------------------------------------------- The SF.Net email is sponsored by EclipseCon 2004 Premiere Conference on Open Tools Development and Integration See the breadth of Eclipse activity. February 3-5 in Anaheim, CA. http://www.eclipsecon.org/osdn _______________________________________________ displaytag-user mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/displaytag-user
