When trying to port setuptools, I found some things I think are bugs,
missing library reorganisation fixes more specifically.

Firstly, there are a lot of things missing from the urllib fixer, most
significantly all the split* methods. Secondly, htmlentitydefs has
moved, and this doesn't seem to be handled.

Am I correct that these are bugs, or should something else be done? A
suggested patch is included, although I haven't made any tests for it,
I wanted to check here first.

-- 
Lennart Regebro: Zope and Plone consulting.
http://www.colliberty.com/
+33 661 58 14 64
Index: fixes/fix_urllib.py
===================================================================
--- fixes/fix_urllib.py	(revision 68179)
+++ fixes/fix_urllib.py	(working copy)
@@ -15,7 +15,10 @@
                      '_urlopener', 'urlcleanup']),
                 ('urllib.parse',
                     ['quote', 'quote_plus', 'unquote', 'unquote_plus',
-                     'urlencode', 'pahtname2url', 'url2pathname']),
+                     'urlencode', 'pahtname2url', 'url2pathname', 'splitattr', 
+                     'splithost', 'splitnport', 'splitpasswd', 'splitport', 
+                     'splitquery', 'splittag', 'splittype', 'splituser', 
+                     'splitvalue', ]),
                 ('urllib.error',
                     ['ContentTooShortError'])],
            'urllib2' : [
@@ -34,7 +37,14 @@
                      'FTPHandler', 'CacheFTPHandler',
                      'UnknownHandler']),
                 ('urllib.error',
-                    ['URLError', 'HTTPError'])],
+                    ['URLError', 'HTTPError']),
+                ('urllib.parse',
+                    ['quote', 'quote_plus', 'unquote', 'unquote_plus',
+                     'urlencode', 'pahtname2url', 'url2pathname', 'splitattr', 
+                     'splithost', 'splitnport', 'splitpasswd', 'splitport', 
+                     'splitquery', 'splittag', 'splittype', 'splituser', 
+                     'splitvalue', ]),
+           ]
 }
 
 
Index: fixes/fix_imports.py
===================================================================
--- fixes/fix_imports.py	(revision 68179)
+++ fixes/fix_imports.py	(working copy)
@@ -55,6 +55,7 @@
            'UserList' : 'collections',
            'urlparse' : 'urllib.parse',
            'robotparser' : 'urllib.robotparser',
+           'htmlentitydefs': 'html.entities',
 }
 
 
_______________________________________________
Distutils-SIG maillist  -  [email protected]
http://mail.python.org/mailman/listinfo/distutils-sig

Reply via email to