Hi Jacob. I've always taken it that the person reviewing will do the marking. (I.e. I don't read it as saying, "Find someone to review it and then mark it RFC yourself", which would contradict the note in the FAQ yes.)
#32559 is on my list. IIRC it was there bar a few last tweaks, so I wanted (want) to get it resolved. C. On Wed, 11 May 2022 at 09:04, Jacob Rief <jacob.r...@gmail.com> wrote: > Hi Carlton, > there is somehow a contradiction: > In https://code.djangoproject.com/wiki/Version4.1Roadmap it's written: > > Better yet, find someone to review your patch and mark the ticket as >> "Ready for checkin". >> > > but > https://docs.djangoproject.com/en/4.0/faq/contributing/#i-m-sure-my-ticket-is-absolutely-100-perfect-can-i-mark-it-as-ready-for-checkin-myself > states: > > >> ’m sure my ticket is absolutely 100% perfect, can I mark it as “Ready For >> Checkin” myself? >> >> Sorry, no. It’s always better to get another set of eyes on a ticket. If >> you’re having trouble getting that second set of eyes, see questions above. >> > > I'm actually asking, because of this I left one of my tickets > <https://code.djangoproject.com/ticket/32559> on "Accepted". > > Kind Regards, > Jacob > > -- > You received this message because you are subscribed to the Google Groups > "Django developers (Contributions to Django itself)" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to django-developers+unsubscr...@googlegroups.com. > To view this discussion on the web visit > https://groups.google.com/d/msgid/django-developers/b4e386d5-b8be-4880-aa29-0c923c986518n%40googlegroups.com > <https://groups.google.com/d/msgid/django-developers/b4e386d5-b8be-4880-aa29-0c923c986518n%40googlegroups.com?utm_medium=email&utm_source=footer> > . > -- You received this message because you are subscribed to the Google Groups "Django developers (Contributions to Django itself)" group. To unsubscribe from this group and stop receiving emails from it, send an email to django-developers+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/django-developers/CAJwKpyRhcYUPUsd47-N8Prrob%3DbjYo6fDVK%3DsHmVzEMuYk%3DOVA%40mail.gmail.com.
