Hi Thomas Your regex looked fine to me. Here's what I did:
- I added "$/DellShare-BrandShare/localdellshare/frames.asp pinned to version 7" to the VssLogParserTest.txt file. - I ran the VssLogParserTest test and it failed. - I added your changes to VssLogParser.cs - I ran the tests and they passed. - I changed the test file to remove the 'Dell'ness :) - Changes committed to CVS. I might have missed something because I do not have a real world VSS log containing a 'pinned' action, but in any case I have committed the changes - it would be good if you could try it out and let us know. I am going to try and release a final beta tomorrow. -MG > -----Original Message----- > From: [EMAIL PROTECTED] > [mailto:[EMAIL PROTECTED] On Behalf > Of Thomas Skovsende > Sent: 05 November 2003 13:55 > To: [EMAIL PROTECTED] > Subject: [Draconet-users] Draco.NET problem > > > Hi there. > > I started to get the following error in the draco.log: > > 05-11-2003 14:22:56 - DellShareAll : Failed to poll > repository for changes because the following exception occurred: > System.Exception: Line 5: Unknown action line:: > $/DellShare-BrandShare/localdellshare/frames.asp pinned to version 7 > at Chive.Draco.Scc.LogParserBase.FireParseException(String message) > at Chive.Draco.Scc.VssLogParser.Next() > at Chive.Draco.Scc.VssLogParser.Parse() > at Chive.Draco.Scc.VssRepository.GetModifications(DateTime > sinceDate) > at Chive.Draco.BuildRunner.GetModifications(DateTime > earliestModificationTime) > at Chive.Draco.BuildRunner.CheckForChanges() > > I looked in the VssLogParser.cs file and looked through the > actions it handled. To my suprise, it seemed to handle the > unpin action, but NOT the pin action. > > I tried to fix this by adding the following code (in latest cvs): > > private Regex actionPinnedRegex = > new Regex(@"^(.*)\spinned\sto\sversion\s(\d+)$"); > > right after the creating of the unpin regex, AND: > > } else if (actionPinnedRegex.IsMatch(action)) { > > m = actionPinnedRegex.Match(action); > type = ModificationType.Other; > file = m.Groups[0].Value; > } > > just after the matching of the unpin action. > > I have tried to check the regular expression, but tbh - I'm > REALLY bad at regexps, so there might be an error there, but > it doesnt seem to work. > > So if anyone could just take a look(and tell me exactly what > I'm doing wrong!), I would be very glad. > > For now i just chose to comment the throwing of an exception, > when it doesnt recognize the event - ugly, but it works for now! ;o) > > Best regards and thanks for any help > > Thomas Skovsende, Netpeople > > > ------------------------------------------------------- > This SF.net email is sponsored by: SF.net Giveback Program. > Does SourceForge.net help you be more productive? Does it > help you create better code? SHARE THE LOVE, and help us help > YOU! Click Here: http://sourceforge.net/donate/ > _______________________________________________ > Draconet-users mailing list [EMAIL PROTECTED] > https://lists.sourceforge.net/lists/listinfo/draconet-users > ------------------------------------------------------- This SF.net email is sponsored by: SF.net Giveback Program. Does SourceForge.net help you be more productive? Does it help you create better code? SHARE THE LOVE, and help us help YOU! Click Here: http://sourceforge.net/donate/ _______________________________________________ Draconet-users mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/draconet-users
