On Wed, Aug 18, 2004 at 01:10:56PM +0100, Dave Airlie wrote:
>
> >
> > A few points (based only on the diff).
> > 1) Rename CONFIG_MTRR to CONFIG_DRM_MTRR to provide better context
>
> well we are using the kernels CONFIG_MTRR so if the kernel has MTRR
> built-in we want to use it
Back home with access to src.
Yes - I realise MTRR is nothing DRM specific so for sure use it as it is.
> .. so I've noticed it already supplies stubs
> for mtrr_add/mtrr_del if it isn't built in so I'll look into removing the
> MTRR detects completely..
>
> > 3) The following code
> > +#if __REALLY_HAVE_AGP && defined(CONFIG_MTRR)
> > + if ( (dev->driver_features & DRIVER_USE_MTRR) && dev->agp && ...
> >
> > Could be replaced by a stub function:
> > #ifdef CONFIG_DRM_MTRR
> > static inline int driver_has_mtrr(...)
> > {
> > return (feature & DRIVER_USE_MTRR) != 0;
> > }
> > #else
> > static inline int driver_has_mtrr(...)
> > {
> > return 0;
> > }
> > #endif
> > This check seems to be used more than one place.
> >
> I might do something like that alright.. looks nicer...
>
> > 4) Use #ifdef, not #if defined()
> > 5) Why not post the diff, makes it _much_ easier to reply wtih code comments.
>
> I'll probably start doing that.. it's just a change in my workflow :-),
> the machine I email from isn't the same one I work on so it means moving
> things around differently..
Good, a bit more trouble for you, but makes it much easier for many..
Sam
-------------------------------------------------------
SF.Net email is sponsored by Shop4tech.com-Lowest price on Blank Media
100pk Sonic DVD-R 4x for only $29 -100pk Sonic DVD+R for only $33
Save 50% off Retail on Ink & Toner - Free Shipping and Free Gift.
http://www.shop4tech.com/z/Inkjet_Cartridges/9_108_r285
--
_______________________________________________
Dri-devel mailing list
[EMAIL PROTECTED]
https://lists.sourceforge.net/lists/listinfo/dri-devel
