On Sat, Jun 11, 2011 at 10:58 PM, Jean Delvare <kh...@linux-fr.org> wrote: > Hi Florian, > > On Sat, 11 Jun 2011 13:28:15 +0200, Florian Mickler wrote: >> On Sat, 04 Jun 2011 19:34:56 -0000 >> Jean Delvare <kh...@linux-fr.org> wrote: >> >> > Revert commit 8f9a3f9b63b8cd3f03be9dc53533f90bd4120e5f. This fixes a >> > hang when loading the eeprom driver (see bug #35572.) GMBUS will be >> > re-enabled later, differently. >> > >> > Signed-off-by: Jean Delvare <kh...@linux-fr.org> >> > Reported-by: Marek Otahal <markota...@gmail.com> >> > Tested-by: Yermandu Patapitafious <yermandu....@gmail.com> >> > Tested-by: Andrew Lutomirski <l...@mit.edu> >> > Acked-by: Chris Wilson <ch...@chris-wilson.co.uk> >> > Cc: David Airlie <airl...@linux.ie> >> >> is this[1] resolved some other way in the meantime? >> >> Regards, >> Flo >> >> [1]: https://bugzilla.kernel.org/show_bug.cgi?id=35572 > > Not that I know of (and I don't see any other way at least for 2.6.39.) > This is a shame, really, my revert patch should have been applied > several days ago already. > > Keith, Chris, David, can you please get it rolling? This is a > regression presumably affecting a lot of users, we should really fix it > quickly, both in 2.6.39.x and 3.0-rc.
This patch really had no info other than the bug link to tell me wtf its doing, I actually don't think reverting this is the correct fix, since it looks like the code path thats screws with the mutex still happens on GEN2 machines which unlucky for them. Chris, also I don't see an ack anywhere on the list, only some discussion in the bug, I suspect the correct fix is to remove all the offending code instead of just putting back the piece of plaster that fell out of the wall. Dave. _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel
