Hi Andrey,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on drm-intel/for-linux-next]
[also build test WARNING on drm-tip/drm-tip drm-exynos/exynos-drm-next 
tegra-drm/drm/tegra/for-next linus/master v5.13-rc1 next-20210510]
[cannot apply to pci/next drm/drm-next]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    
https://github.com/0day-ci/linux/commits/Andrey-Grodzovsky/RFC-Support-hot-device-unplug-in-amdgpu/20210511-003754
base:   git://anongit.freedesktop.org/drm-intel for-linux-next
config: x86_64-randconfig-a012-20210510 (attached as .config)
compiler: clang version 13.0.0 (https://github.com/llvm/llvm-project 
492173d42b32cb91d5d0d72d5ed84fcab80d059a)
reproduce (this is a W=1 build):
        wget 
https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O 
~/bin/make.cross
        chmod +x ~/bin/make.cross
        # install x86_64 cross compiling tool for clang build
        # apt-get install binutils-x86-64-linux-gnu
        # 
https://github.com/0day-ci/linux/commit/28901216b0a25add4057d60c10eb305d4a32535e
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review 
Andrey-Grodzovsky/RFC-Support-hot-device-unplug-in-amdgpu/20210511-003754
        git checkout 28901216b0a25add4057d60c10eb305d4a32535e
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 
ARCH=x86_64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <l...@intel.com>

All warnings (new ones prefixed by >>):

   drivers/gpu/drm/amd/amdgpu/amdgpu_fence.c:444: warning: Function parameter 
or member 'sched_score' not described in 'amdgpu_fence_driver_init_ring'
>> drivers/gpu/drm/amd/amdgpu/amdgpu_fence.c:527: warning: expecting prototype 
>> for amdgpu_fence_driver_fini(). Prototype was for 
>> amdgpu_fence_driver_fini_hw() instead
--
>> drivers/gpu/drm/amd/amdgpu/amdgpu_device.c:3652: warning: expecting 
>> prototype for amdgpu_device_fini(). Prototype was for 
>> amdgpu_device_fini_hw() instead
--
>> drivers/gpu/drm/amd/amdgpu/amdgpu_irq.c:376: warning: expecting prototype 
>> for amdgpu_irq_fini(). Prototype was for amdgpu_irq_fini_sw() instead


vim +527 drivers/gpu/drm/amd/amdgpu/amdgpu_fence.c

d38ceaf99ed015 Alex Deucher      2015-04-20  517  
d38ceaf99ed015 Alex Deucher      2015-04-20  518  /**
d38ceaf99ed015 Alex Deucher      2015-04-20  519   * amdgpu_fence_driver_fini - 
tear down the fence driver
d38ceaf99ed015 Alex Deucher      2015-04-20  520   * for all possible rings.
d38ceaf99ed015 Alex Deucher      2015-04-20  521   *
d38ceaf99ed015 Alex Deucher      2015-04-20  522   * @adev: amdgpu device 
pointer
d38ceaf99ed015 Alex Deucher      2015-04-20  523   *
d38ceaf99ed015 Alex Deucher      2015-04-20  524   * Tear down the fence driver 
for all possible rings (all asics).
d38ceaf99ed015 Alex Deucher      2015-04-20  525   */
28901216b0a25a Andrey Grodzovsky 2021-05-10  526  void 
amdgpu_fence_driver_fini_hw(struct amdgpu_device *adev)
d38ceaf99ed015 Alex Deucher      2015-04-20 @527  {
c89377d10a11e5 Christian König   2016-03-13  528        unsigned i, j;
c89377d10a11e5 Christian König   2016-03-13  529        int r;
d38ceaf99ed015 Alex Deucher      2015-04-20  530  
d38ceaf99ed015 Alex Deucher      2015-04-20  531        for (i = 0; i < 
AMDGPU_MAX_RINGS; i++) {
d38ceaf99ed015 Alex Deucher      2015-04-20  532                struct 
amdgpu_ring *ring = adev->rings[i];
c2776afe740db5 Christian König   2015-11-03  533  
d38ceaf99ed015 Alex Deucher      2015-04-20  534                if (!ring || 
!ring->fence_drv.initialized)
d38ceaf99ed015 Alex Deucher      2015-04-20  535                        
continue;
bb0cd09be45ea4 Emily Deng        2021-03-04  536                if 
(!ring->no_scheduler)
bb0cd09be45ea4 Emily Deng        2021-03-04  537                        
drm_sched_fini(&ring->sched);
d38ceaf99ed015 Alex Deucher      2015-04-20  538                r = 
amdgpu_fence_wait_empty(ring);
d38ceaf99ed015 Alex Deucher      2015-04-20  539                if (r) {
d38ceaf99ed015 Alex Deucher      2015-04-20  540                        /* no 
need to trigger GPU reset as we are unloading */
2f9d4084cac96a Monk Liu          2017-10-16  541                        
amdgpu_fence_driver_force_completion(ring);
d38ceaf99ed015 Alex Deucher      2015-04-20  542                }
55611b507fd645 Jack Xiao         2019-06-05  543                if 
(ring->fence_drv.irq_src)
c6a4079badc2f0 Chunming Zhou     2015-06-01  544                        
amdgpu_irq_put(adev, ring->fence_drv.irq_src,
c6a4079badc2f0 Chunming Zhou     2015-06-01  545                                
       ring->fence_drv.irq_type);
bb0cd09be45ea4 Emily Deng        2021-03-04  546  
8c5e13ec6a2c26 Andrey Grodzovsky 2018-09-21  547                
del_timer_sync(&ring->fence_drv.fallback_timer);
28901216b0a25a Andrey Grodzovsky 2021-05-10  548        }
28901216b0a25a Andrey Grodzovsky 2021-05-10  549  }
28901216b0a25a Andrey Grodzovsky 2021-05-10  550  

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-...@lists.01.org

Attachment: .config.gz
Description: application/gzip

Reply via email to