Hi Ezequiel, Thanks for your suggestion.
On Thu, 2021-10-14 at 09:38 -0300, Ezequiel Garcia wrote: > Hi Yunfei, > > On Tue, 12 Oct 2021 at 22:17, yunfei.d...@mediatek.com > <yunfei.d...@mediatek.com> wrote: > > Hi Ezequiel, > > > > Thanks for your feedback, > > > > The driver can work well now according to your advice with > > of_platform_populate interface. > > > > In order to separate parent node with children node, parent node > > is > > master device, children node is component device. > > > > The master and component are registered platform device. > > > > > > Could you please help to review the patch again when you are free: > > > > https://patchwork.linuxtv.org/project/linux-media/cover/20211011070247.792-1-yunfei.d...@mediatek.com/ > > > > I'm glad you managed to simplify the driver. I tried applying the > patches > but they don't apply on media master. Please push a branch to gitlab > or github > or somewhere public. > > Keep in mind that when you need people to review your code, > it's generally good practice to try to make it easy on them. > The harder you make it, the less inclined people will be to > spend time on your work. > I will send the patch v8 base on media tree, and I already test it in my local environment. And you can get media_tree then sync patch v8. > Thanks, > Ezequiel Thanks Yunfei Dong