Hi Marek, Thank you for the patch.
On Wed, May 15, 2024 at 08:27:44AM +0200, Marek Vasut wrote: > The DW HDMI driver core is responsible for parsing the 'ddc-i2c-bus' property, > move the property description into the DW HDMI common DT schema too, so this > property can be used on all devices integrating the DW HDMI core. De-duplicating documentation is good :-) I see no reason why this property should be disallowed on any of the platforms that integrate a DW HDMI (unless that platform has no other I2C controller, but I think we can ignore that in the bindings). There could be platforms where the DW HDMI DDC pins are not exposed, making the ddc-i2c-bus property mandatory, but that's something for platform-specific bindings to handle by simply adding a required: - ddc-i2c-bus That's a separate issue. This patch looks good to me. Reviewed-by: Laurent Pinchart <laurent.pinchart+rene...@ideasonboard.com> > Signed-off-by: Marek Vasut <ma...@denx.de> > --- > Cc: Andrzej Hajda <andrzej.ha...@intel.com> > Cc: Conor Dooley <conor...@kernel.org> > Cc: Daniel Vetter <dan...@ffwll.ch> > Cc: David Airlie <airl...@gmail.com> > Cc: Fabio Estevam <feste...@gmail.com> > Cc: Jernej Skrabec <jernej.skra...@gmail.com> > Cc: Jonas Karlman <jo...@kwiboo.se> > Cc: Krzysztof Kozlowski <krzk...@kernel.org> > Cc: Laurent Pinchart <laurent.pinch...@ideasonboard.com> > Cc: Liu Ying <victor....@nxp.com> > Cc: Maarten Lankhorst <maarten.lankho...@linux.intel.com> > Cc: Maxime Ripard <mrip...@kernel.org> > Cc: Neil Armstrong <neil.armstr...@linaro.org> > Cc: Pengutronix Kernel Team <ker...@pengutronix.de> > Cc: Philipp Zabel <p.za...@pengutronix.de> > Cc: Rob Herring <r...@kernel.org> > Cc: Robert Foss <rf...@kernel.org> > Cc: Sascha Hauer <s.ha...@pengutronix.de> > Cc: Shawn Guo <shawn...@kernel.org> > Cc: Thomas Zimmermann <tzimmerm...@suse.de> > Cc: devicet...@vger.kernel.org > Cc: dri-devel@lists.freedesktop.org > Cc: i...@lists.linux.dev > Cc: ker...@dh-electronics.com > Cc: linux-arm-ker...@lists.infradead.org > --- > V2: Update rockchip,dw-hdmi.yaml as well > --- > .../bindings/display/bridge/synopsys,dw-hdmi.yaml | 8 ++++++++ > .../devicetree/bindings/display/imx/fsl,imx6-hdmi.yaml | 8 -------- > .../bindings/display/rockchip/rockchip,dw-hdmi.yaml | 8 -------- > 3 files changed, 8 insertions(+), 16 deletions(-) > > diff --git > a/Documentation/devicetree/bindings/display/bridge/synopsys,dw-hdmi.yaml > b/Documentation/devicetree/bindings/display/bridge/synopsys,dw-hdmi.yaml > index 4b7e54a8f037f..828709a8ded26 100644 > --- a/Documentation/devicetree/bindings/display/bridge/synopsys,dw-hdmi.yaml > +++ b/Documentation/devicetree/bindings/display/bridge/synopsys,dw-hdmi.yaml > @@ -45,6 +45,14 @@ properties: > - const: isfr > additionalItems: true > > + ddc-i2c-bus: > + $ref: /schemas/types.yaml#/definitions/phandle > + description: > + The HDMI DDC bus can be connected to either a system I2C master or the > + functionally-reduced I2C master contained in the DWC HDMI. When > connected > + to a system I2C master this property contains a phandle to that I2C > + master controller. > + > interrupts: > maxItems: 1 > > diff --git a/Documentation/devicetree/bindings/display/imx/fsl,imx6-hdmi.yaml > b/Documentation/devicetree/bindings/display/imx/fsl,imx6-hdmi.yaml > index 7979cf07f1199..180c4b510fb12 100644 > --- a/Documentation/devicetree/bindings/display/imx/fsl,imx6-hdmi.yaml > +++ b/Documentation/devicetree/bindings/display/imx/fsl,imx6-hdmi.yaml > @@ -31,14 +31,6 @@ properties: > clock-names: > maxItems: 2 > > - ddc-i2c-bus: > - $ref: /schemas/types.yaml#/definitions/phandle > - description: > - The HDMI DDC bus can be connected to either a system I2C master or the > - functionally-reduced I2C master contained in the DWC HDMI. When > connected > - to a system I2C master this property contains a phandle to that I2C > - master controller. > - > gpr: > $ref: /schemas/types.yaml#/definitions/phandle > description: > diff --git > a/Documentation/devicetree/bindings/display/rockchip/rockchip,dw-hdmi.yaml > b/Documentation/devicetree/bindings/display/rockchip/rockchip,dw-hdmi.yaml > index 2aac62219ff64..9d096856a79a6 100644 > --- a/Documentation/devicetree/bindings/display/rockchip/rockchip,dw-hdmi.yaml > +++ b/Documentation/devicetree/bindings/display/rockchip/rockchip,dw-hdmi.yaml > @@ -70,14 +70,6 @@ properties: > - vpll > - ref > > - ddc-i2c-bus: > - $ref: /schemas/types.yaml#/definitions/phandle > - description: > - The HDMI DDC bus can be connected to either a system I2C master or the > - functionally-reduced I2C master contained in the DWC HDMI. When > connected > - to a system I2C master this property contains a phandle to that I2C > - master controller. > - > phys: > maxItems: 1 > description: The HDMI PHY -- Regards, Laurent Pinchart
