Re: [PATCH v3 6/6] drm/panel: simple: Add Microtips Technology MF-103HIEB0GA0 panel

[Liu Ying]

On 5/15/24 17:51, Aradhya Bhatia wrote:
> Add support for Microtips Technology USA MF-103HIEB0GA0 10.25"[0],
> 1920x720, 8-bit TFT LCD with LVDS interface. Its a Dual-LVDS Panel and
> does not support touch.
> 
> [0]: Panel Datasheet
> https://simplespec.microtipsusa.com/uploads/spec/datasheetFile/2660/13-103HIEB0GA0-S_V1.0_20211206.pdf
> 
> Signed-off-by: Aradhya Bhatia <a-bhat...@ti.com>
> ---
>  drivers/gpu/drm/panel/panel-simple.c | 32 ++++++++++++++++++++++++++++
>  1 file changed, 32 insertions(+)

Like my comments for patch 3/6, this panel is not simple enough
for this driver.

Regards,
Liu Ying

> 
> diff --git a/drivers/gpu/drm/panel/panel-simple.c 
> b/drivers/gpu/drm/panel/panel-simple.c
> index 3a0d8f0ff267..1b0a6b4e034c 100644
> --- a/drivers/gpu/drm/panel/panel-simple.c
> +++ b/drivers/gpu/drm/panel/panel-simple.c
> @@ -3084,6 +3084,35 @@ static const struct panel_desc 
> microtips_mf_101hiebcaf0_c = {
>       .connector_type = DRM_MODE_CONNECTOR_LVDS,
>  };
>  
> +static const struct drm_display_mode microtips_mf_103hieb0ga0_mode = {
> +     .clock = 93301,
> +     .hdisplay = 1920,
> +     .hsync_start = 1920 + 72,
> +     .hsync_end = 1920 + 72 + 72,
> +     .htotal = 1920 + 72 + 72 + 72,
> +     .vdisplay = 720,
> +     .vsync_start = 720 + 3,
> +     .vsync_end = 720 + 3 + 3,
> +     .vtotal = 720 + 3 + 3 + 2,
> +};
> +
> +static const struct panel_desc microtips_mf_103hieb0ga0 = {
> +     .modes = &microtips_mf_103hieb0ga0_mode,
> +     .bpc = 8,
> +     .num_modes = 1,
> +     .size = {
> +             .width = 244,
> +             .height = 92,
> +     },
> +     .delay = {
> +             .prepare = 50,
> +             .disable = 50,
> +     },
> +     .bus_flags = DRM_BUS_FLAG_DE_HIGH,
> +     .bus_format = MEDIA_BUS_FMT_RGB888_1X7X4_SPWG,
> +     .connector_type = DRM_MODE_CONNECTOR_LVDS,
> +};
> +
>  static const struct drm_display_mode mitsubishi_aa070mc01_mode = {
>       .clock = 30400,
>       .hdisplay = 800,
> @@ -4726,6 +4755,9 @@ static const struct of_device_id platform_of_match[] = {
>       }, {
>               .compatible = "microtips,mf-101hiebcaf0",
>               .data = &microtips_mf_101hiebcaf0_c,
> +     }, {
> +             .compatible = "microtips,mf-103hieb0ga0",
> +             .data = &microtips_mf_103hieb0ga0,
>       }, {
>               .compatible = "mitsubishi,aa070mc01-ca1",
>               .data = &mitsubishi_aa070mc01,