> -----Original Message----- > From: Rafa? Mi?ecki [mailto:zajec5 at gmail.com] > Sent: Thursday, March 29, 2012 4:17 AM > To: alexdeucher at gmail.com > Cc: airlied at gmail.com; dri-devel at lists.freedesktop.org; Deucher, > Alexander > Subject: Re: [PATCH] drm/radeon/kms: add register definitions for audio > > 2012/3/28 <alexdeucher at gmail.com>: > > +/* digital blocks */ > > +#define TMDSA_CNTL ? ? ? ? ? ? ? ? ? ? ? 0x7880 > > +# ? ? ? define TMDSA_HDMI_EN ? ? ? ? ? ? (1 << 2) > > +#define LVTMA_CNTL ? ? ? ? ? ? ? ? ? ? ? 0x7a80 > > +# ? ? ? define LVTMA_HDMI_EN ? ? ? ? ? ? (1 << 2) > > +#define DDIA_CNTL ? ? ? ? ? ? ? ? ? ? ? ?0x7200 > > +# ? ? ? define DDIA_HDMI_EN ? ? ? ? ? ? ?(1 << 2) > > +#define DIG0_CNTL ? ? ? ? ? ? ? ? ? ? ? ?0x75a0 > > +# ? ? ? define DIG_MODE(x) ? ? ? ? ? ? ? (((x) & 7) << 8) > > +# ? ? ? define DIG_MODE_DP ? ? ? ? ? ? ? 0 > > +# ? ? ? define DIG_MODE_LVDS ? ? ? ? ? ? 1 > > +# ? ? ? define DIG_MODE_TMDS_DVI ? ? ? ? 2 > > +# ? ? ? define DIG_MODE_TMDS_HDMI ? ? ? ?3 > > +# ? ? ? define DIG_MODE_SDVO ? ? ? ? ? ? 4 > > +#define DIG1_CNTL ? ? ? ? ? ? ? ? ? ? ? ?0x79a0 > > TMDSA and LVTMA seem to be duplicated. Not sure if you want to have > them in 2 places?
It's fine. It depends where the headers are used. Alex > > -- > Rafa?
