On Wed, 17 Jul 2002, Keith Whitwell wrote: > >>I've done all the others. Lets see if testing was required... > >> > > > > So, should I commit the fix for r128? I've tested that and it works fine. > > Yes, go ahead. > > > I took a look at the other drivers concerning the read buffer fix. It > > looks like mga, i810, and i830 already do this correctly. Reading from a > > separate read buffer doesn't seem to be implemented on tdfx and sis. It > > looks like ffb, gamma, r128, and radeon need the fix. The attached patch > > has fixes for all the drivers except sis (I included tdfx even though the > > ReadBuffer isn't used). I've tested the read buffer fix on mach64 and > > r128 with texenv (single-buffer mode), checking to see that textures done > > in software are correctly blended with the front buffer when the > > background is turned off (the checker-board should show through in the > > transparent areas). You'd have to force a fallback to test this on Radeon > > or other drivers without texture fallbacks. > > Sounds good - go ahead & commit this to.
OK, these are both committed. I've only tested the read buffer fix on r128, but I don't forsee any problems. For most drivers with few fallbacks, the problem probably went unnoticed anyway. Thanks for the clipping fix Keith, your one line beat my original 'fix' by a mile! -- Leif Delgass http://www.retinalburn.net ------------------------------------------------------- This sf.net email is sponsored by:ThinkGeek Welcome to geek heaven. http://thinkgeek.com/sf _______________________________________________ Dri-devel mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/dri-devel
