On Wed, Feb 12, 2014 at 12:44:43PM -0500, Mark Hounschell wrote:
> Merge dgap_fep5.c into dgap_driver.c
> 
> Signed-off-by: Mark Hounschell <ma...@compro.net>
> Cc: Greg Kroah-Hartman <gre...@linuxfoundation.org>

A good changelog comment doesn't just say what happens, but _why_ it is
happening.

Why are you merging these files?

> 
> diff -urN linux-3.13.1-orig/drivers/staging/dgap/dgap_driver.c 
> linux-3.13.1-new/drivers/staging/dgap/dgap_driver.c
> --- linux-3.13.1-orig/drivers/staging/dgap/dgap_driver.c      2014-01-29 
> 08:06:37.000000000 -0500
> +++ linux-3.13.1-new/drivers/staging/dgap/dgap_driver.c       2014-01-31 
> 10:22:53.675819451 -0500

Did you generate this with git?  What happened to the diffstat?

thanks,

greg k-h
_______________________________________________
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Reply via email to