[
https://jira.duraspace.org/browse/DS-768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=21972#comment-21972
]
Kim Shepherd commented on DS-768:
---------------------------------
I've been testing out what Tim tried as well, and in cases where we actually
throw a Cocoon exception (eg. try a /browse?type=invalidbrowseindex), we can
alter the status code thrown in sitemap.xmap. For example, I know an exception
is thrown on invalid browse index (it's *supposed* to be a RESOURCE_NOT_FOUND,
but some stuff left over form DS-754 means it's throwing a NPE instead), so I
changed the default exception handling to throw a random status code (eg. 777),
and it does.
Speculation: Part of the problem could be that when a resource is missing or a
path is invalid, we're not throwing the right kind of Cocoon exception, and so
it's not matching <map:handle-errors>...
Here's an example of what PageNotFoundTransformer does:
HttpServletResponse response =
(HttpServletResponse)objectModel.get(HttpEnvironment.HTTP_RESPONSE_OBJECT);
response.setStatus(HttpServletResponse.SC_NOT_FOUND);
Rather than the "typical" choice of throwing a Cocoon ResourceNotFoundException.
> All XMLUI Error Pages respond with 200 OK, instead of 404 Not Found
> -------------------------------------------------------------------
>
> Key: DS-768
> URL: https://jira.duraspace.org/browse/DS-768
> Project: DSpace
> Issue Type: Bug
> Components: XMLUI
> Affects Versions: 1.6.0, 1.6.1, 1.6.2, 1.7.0
> Reporter: Tim Donohue
> Assignee: Kim Shepherd
> Priority: Major
> Fix For: 1.8.0
>
> Attachments: [DS-768]_dspace-cocoon-servlet-service-impl-1_0_2.patch,
> dspace-cocoon-servlet-service-impl-1.0.2.jar
>
>
> In DSpace 1.7.0 RC1, the XMLUI "Page Not Found" page responds with a 200 OK,
> rather than the necessary 404 Not Found error.
> For example:
> http://demo.dspace.org/xmlui/NOTAVALIDPATH
> I believe this used to function properly in 1.6.x, but it seems to be broken
> now.
> Obviously, we want this to return a 404 Not Found, in order to ensure that
> search engines do not index "Page Not Found" responses.
> Furthermore, it has been discovered that all other XMLUI Error pages (Cocoon
> Errors or Invalid Continuation errors) also respond with 200 OK. In
> addition, it seems this affects all 1.6.x versions of DSpace, as the same
> responses can be found on http://dspace.mit.edu (currently running 1.6.0 with
> patches), and http://researchspace.auckland.ac.nz (currently running 1.6.2
> with patches).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://jira.duraspace.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
------------------------------------------------------------------------------
Get a FREE DOWNLOAD! and learn more about uberSVN rich system,
user administration capabilities and model configuration. Take
the hassle out of deploying and managing Subversion and the
tools developers use with it. http://p.sf.net/sfu/wandisco-d2d-2
_______________________________________________
Dspace-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/dspace-devel
