[
https://jira.duraspace.org/browse/DS-768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=22417#comment-22417
]
Mark Diggory commented on DS-768:
---------------------------------
tdonohue: Ok, I specifically wanted to ask to see if anyone has an ideas/time
to spend on DS-768. From my understanding, kshepherd has gotten decently far,
but he has rescheduled it for post-1.8.0 cause he needs feedback & help
[8:06pm] tdonohue: https://jira.duraspace.org/browse/DS-768
[8:06pm] keithgilbertson joined the chat room.
[8:06pm] tdonohue: it'd be good to finally get this fixed, if anyone can spend
some time in the coming weeks. It's annoying that we cannot get XMLUI to throw
a proper 404
[8:07pm] hpottinger: I'm happy to run that patch on my testathon instance,
someone talk me out of it
[8:08pm] aschweer: hpottinger: I think it sounds like a good idea
[8:08pm] tdonohue: go for it!
[8:08pm] • mhwood tries unsuccessfully to talk him out of it
[8:08pm] aschweer: to me it sounds like kshepherd is worried that his fix
breaks other things (because of cocoon patches), and I guess we won't find out
unless we run it
[8:09pm] tdonohue: yea, I think that's right aschweer. We mainly need more
testing / testers / eyes on what kshepherd has proposed
[8:10pm] mdiggory: Perhaps I should take a look at this, I did recently rip
apart cocoon servlet service once again
[8:10pm] tdonohue: ok. sounds like we can test it out on hpottinger's test
instance and see how it goes.
[8:10pm] tdonohue: mdiggory: it'd be great if you could
[8:10pm] hpottinger: will try to have it patched and running by 10pm tonight
[8:11pm] tdonohue: mainly, I want to avoid having yet another release where our
XMLUI just always says "200 OK"
[8:11pm] mdiggory: We did plan to drop the code here
[8:11pm] mdiggory:
http://scm.dspace.org/svn/repo/modules/dspace-cocoon-servlet-service-impl/
[8:12pm] robint: Looks like its still just attached to the Jira issue
[8:13pm] mdiggory: I beleive what we should do is dump the cocoon source under
modules, commit it, patch it, release a SNAPSHOT, have testathon instances test
building with the snapshot in place
[8:14pm] sandsfish joined the chat room.
[8:15pm] mdiggory: We might be better served to throw
org/apache/cocoon/ProcessingException.html rather than
ResourceNotFoundException, it would allow us to trap other conditions later as
well.
[8:15pm] mdiggory: Direct Known Subclasses:
[8:15pm] mdiggory: ConnectionResetException, FormsException,
InvalidContinuationException, ResourceNotFoundException
[8:15pm] tdonohue: i'm fine with that direction, as long as we get some more
eyes on what kshepherd proposes first. I just don't want to post it to
demo.dspace.org until we have some idea that it should 'work'
[8:17pm] tdonohue: mdiggory, do you want to bring your ideas to DS-768
comments, or to dspace-devel? I think this sounds reasonable, just don't want
to take up all the meeting on just this one issue (we've got many more that are
still open as well)
[8:17pm] hpottinger: looks like this is the patch I need to try:
https://jira.duraspace.org/secure/attachment/11922/add_ResourceNotFoundException_to_xmlui_transformers.patch
but willing to try something else, as long as I have a patch to apply
[8:17pm] mdiggory: continue on, I'll comment in the ticket and start progress.
> All XMLUI Error Pages respond with 200 OK, instead of 404 Not Found
> -------------------------------------------------------------------
>
> Key: DS-768
> URL: https://jira.duraspace.org/browse/DS-768
> Project: DSpace
> Issue Type: Bug
> Components: XMLUI
> Affects Versions: 1.6.0, 1.6.1, 1.6.2, 1.7.0, 1.8.0
> Reporter: Tim Donohue
> Assignee: Kim Shepherd
> Priority: Major
> Fix For: post-1.8.0
>
> Attachments:
> add_ResourceNotFoundException_to_xmlui_transformers.patch,
> [DS-768]_dspace-cocoon-servlet-service-impl-1_0_2.patch,
> dspace-cocoon-servlet-service-impl-1.0.2.jar, Screen shot 2011-08-17 at
> 2.20.40 PM.png
>
>
> In DSpace 1.7.0 RC1, the XMLUI "Page Not Found" page responds with a 200 OK,
> rather than the necessary 404 Not Found error.
> For example:
> http://demo.dspace.org/xmlui/NOTAVALIDPATH
> I believe this used to function properly in 1.6.x, but it seems to be broken
> now.
> Obviously, we want this to return a 404 Not Found, in order to ensure that
> search engines do not index "Page Not Found" responses.
> Furthermore, it has been discovered that all other XMLUI Error pages (Cocoon
> Errors or Invalid Continuation errors) also respond with 200 OK. In
> addition, it seems this affects all 1.6.x versions of DSpace, as the same
> responses can be found on http://dspace.mit.edu (currently running 1.6.0 with
> patches), and http://researchspace.auckland.ac.nz (currently running 1.6.2
> with patches).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://jira.duraspace.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
------------------------------------------------------------------------------
BlackBerry® DevCon Americas, Oct. 18-20, San Francisco, CA
Learn about the latest advances in developing for the
BlackBerry® mobile platform with sessions, labs & more.
See new tools and technologies. Register for BlackBerry® DevCon today!
http://p.sf.net/sfu/rim-devcon-copy1
_______________________________________________
Dspace-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/dspace-devel
