Or maybe, you keep DCValue but it holds references to the Metadata* objects. I probably need to think about this more...
On 05/11/12 10:00, TAYLOR Robin wrote: > Hi all, > > I think DCValue was deprecated to be replaced by MetadataSchemaRegistry, > MetadataFieldRegistry, and MetadataValue. At the moment an Item only has > references to its DCValues, it doesn't have references to the > constituent Meatadata* objects. I don't know what the original reasoning > was but I do know there are some downsides to using DCValue eg. if you > wanted to extend the use of resource policies to metatadata fields or > even metadata values you can't because an Item doesn't know about these > objects, it only knows about the compound object DCValue. Getting rid of > DCValue would be a good thing in my opinion but it would not be be easy, > you would need to change Item to directly use the Metadata* classes > rather than DCValue. > > Cheers, Robin. > > > On 05/11/12 00:10, Mark H. Wood wrote: >> On Fri, Nov 02, 2012 at 10:13:27PM +0100, helix84 wrote: >>> On Fri, Nov 2, 2012 at 10:04 PM, Mark H. Wood <[email protected]> wrote: >>>> I think the rest of the warnings will mostly be deprecation, and that the >>>> vast majority of *those* are about DCValue. >>> Mark, I was curious about those. Where can I read something regarding >>> DCValue depreciation (why, what replaces it)? >> Very good questions. I wish I had answers. I spend a couple of hours >> once staring at it, trying to figure out which of the Metadata* >> classes was supposed to replace DCValue (so I might complete the work >> and get rid of all the warnings), but it never became clear to me. >> >> I don't know who deprecated DCValue, nor why. "Why" might become >> obvious if I look at it again. >> >>> Can you also give me a brief status update? >> On DCValue? I'm not aware that anyone is working on it. >> >> On cleaning up Javadoc warnings? I just dumped out what I had >> completed before leaving for the day, and haven't been back to it >> since. I want to finish up on Monday, to the extent I can finish. >> There are a few comments that I could neither properly repair nor in >> good conscience just remove, and I'm hoping that someone with deeper >> understanding of those places will come along behind me and finish the >> work. >> >> I would say that the majority of the doc comment warnings were >> "missing value of @return". On getters I generally just removed the >> empty @return, and elsewhere I tried to work out what was returned. >> If it was thoroughly obvious from the method description then I again >> removed the (redundant) @return. >> >> I have no doubt that I've missed some nuances that would be good to >> document, but at least the compiler is quieter now. >> > -- The University of Edinburgh is a charitable body, registered in Scotland, with registration number SC005336. ------------------------------------------------------------------------------ LogMeIn Central: Instant, anywhere, Remote PC access and management. Stay in control, update software, and manage PCs from one command center Diagnose problems and improve visibility into emerging IT issues Automate, monitor and manage. Do more in less time with Central http://p.sf.net/sfu/logmein12331_d2d _______________________________________________ Dspace-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/dspace-devel
