[ 
https://jira.duraspace.org/browse/DS-1401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=27063#comment-27063
 ] 

Ivan Masár commented on DS-1401:
--------------------------------

You're telling me now when I ran the workaround! :D

No, seriously, thanks for looking into that. I tested it and it works.

The documentation really doesn't help in this case. But I wouldn't change the 
behaviour of the class itself:
1) it would introduce different behaviour for different versions if DSpace; not 
a problem, but it is a source of confusion
2) if you implement wildcard matching in Java, the argument will have to be 
passed in quotes; this can again cause confusion
3) if rely on wildcard expansion in shell and just take the list of arguments 
in Java, it can happen that the commandline will be very long (easy to achieve 
in this use case) and that may cause problems in itself.

So I think the best fix is just to clarify the documentation. I will do so.
                
> "stats-log-converter -m" not working
> ------------------------------------
>
>                 Key: DS-1401
>                 URL: https://jira.duraspace.org/browse/DS-1401
>             Project: DSpace
>          Issue Type: Improvement
>    Affects Versions: 3.0
>            Reporter: Ivan Masár
>             Fix For: 3.0
>
>
> When I run
> /dspace/bin/dspace stats-log-converter -m -i /dspace/log/dspace.log* -o 
> statistics.log -n
> only the first file matched is converted (e.g. dspace.log.2012-09-12).
> I'm judging I'm not the only one who has this problem because I found this 
> page suggesting a workaround:
> http://wiki.lib.sun.ac.za/index.php/SUNScholar/Asset_Statistics/Old_Versions
> That workaround is inefficient because it requires starting up the JVM once 
> for each day of statistics processed.
> The relevant code is here:
> https://github.com/DSpace/DSpace/blob/master/dspace-api/src/main/java/org/dspace/statistics/util/ClassicDSpaceLogConverter.java#L345

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

------------------------------------------------------------------------------
Monitor your physical, virtual and cloud infrastructure from a single
web console. Get in-depth insight into apps, servers, databases, vmware,
SAP, cloud infrastructure, etc. Download 30-day Free Trial.
Pricing starts from $795 for 25 servers or applications!
http://p.sf.net/sfu/zoho_dev2dev_nov
_______________________________________________
Dspace-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/dspace-devel

Reply via email to