Tim, Obviously there has to be binding between the JSP interface and the processing class - however, I don't see why that needs to be a class extended from the main processing class.
So, like xmlui, you could just specify a 'binding' class that implements the JSP binding interface (doPreProcessing / doPostProcessing), and the controller can simply call that around the main processing class. This binding implementation could also include the path to the review JSP (getReviewJSP) - it already encapsulates the submission form. There is no reason for the heading to be a full key name - it can just be a description, and the controller for the XML or JSP interface can prefix it with 'jsp.submit.' or 'xmlui.Submission.' as appropriate. It would mean changing the full key used in at least one of the JSP or XML interfaces, but as that means better harmonisation between the interfaces, that's no bad thing. The net result would be a configuration that looks something like: <step> <heading>general.progress.describe</heading> <processing-class>org.dspace.submit.step.DescribeStep</processing-class> <jsp-binding>org.dspace.app.webui.submit.step.DescribeStepBinding</jsp-binding> <xmlui-binding>org.dspace.app.xmlui.aspect.submission.submit.DescribeStepBinding</xmlui-binding> <workflow-editable>true</workflow-editable> </step> G On Fri, 2008-01-04 at 09:10 -0600, Tim Donohue wrote: > Scott, > > There's still unfortunately two XML files, since the "step" definitions > for both the JSPUI and XMLUI differ quite a bit. Take for example the > "Describe" step definitions: > > 'Describe' for JSPUI: > > <step> > <heading>jsp.submit.progressbar.describe</heading> > <processing-class>org.dspace.app.webui.submit.step.JSPDescribeStep</processing-class> > <review-jsp>/submit/review-metadata.jsp</review-jsp> > <workflow-editable>true</workflow-editable> > </step> > > 'Describe' for XMLUI: > > <step> > <heading>xmlui.Submission.general.progress.describe</heading> > <processing-class>org.dspace.submit.step.DescribeStep</processing-class> > > <xml-ui-class>org.dspace.app.xmlui.aspect.submission.submit.DescribeStep</xml-ui-class> > <workflow-editable>true</workflow-editable> > </step> > > > You'll notice they are almost entirely different...there are a few > things going on here: > > (1) The JSPUI and XMLUI use different I18N, so they need to have > differently specified <heading> tags (which correspond to the > appropriate I18N key) > > (2) The JSPUI requires a special JSP "processing" class, which > implements JSPStep to do appropriate pre/post-processing in order to > pass appropriate parameters to the JSPs for display. The JSPUI also > needs a special "<review-jsp>", which is loaded by the "Review" step to > allow it to be dynamic enough to review all steps in the proper order. > > (3) The XMLUI has an <xml-ui-class> which acts as the Step "Transformer" > necessary for Manakin, and builds the display for that interface. > > Believe me, I've tried to figure out a simple way to merge these two > XMLs. But, unfortunately, since the differences between the JSPUI and > XMLUI are too great, I haven't been able to come up with an easy > resolution to the issue. If someone else has an extra pair of eyes to > look more closely at this before the final 1.5 version, maybe there's a > resolution that I'm overlooking. > > My only other thought has been to actually put both configurations in > one gigantic configuration file, and mark a <submission-process> as > being either "interface=xmlui" or "interface=jspui". But, I haven't had > the time to rework the API to support this (although, I may be able to > free up time to do so, if everyone else thinks this is the better way of > doing things). > > -Tim > > > Scott Phillips wrote: > > Mika + Tim, > > > > I was under the impression that the two xml files had been merged > > together so you only need one supported by either XMLUI or JSPUI? The > > XMLUI only adds an extra tag in it for which presentation class to use. > > > > Tim can you shed any light on this? > > > > Scott-- > > > > > > On Jan 3, 2008, at 8:07 AM, Claudia Juergen wrote: > > > >> Hi Mika, > >> > >> the configuration files for the submission process are: > >> > >> [dspace]/config/item-submission-JSPUI.xml > >> and > >> [dspace]/config/item-submission-XMLUI.xml > >> > >> As for the metadata elements, they are still configured via the > >> input-forms.xml > >> > >> see [dspace]/docs/submission.html for details > >> > >> hope that helps > >> > >> Claudia > >> > >>> This fixed it. I had copied my old dspace.cfg on top of the old > >>> one. Now > >>> it seems to work. > >>> > >>> I understood that the configurable submission patch was included in > >>> 1.5. > >>> How can I use it and customize the submission process? I couldnt find > >>> any tools for it in the WebUI? > >>> > >>> Thanks, > >>> Mika > >>> > >>> > >>> > >>>> Mika, > >>>> > >>>> That looks like there was not an filtering of the db properties > >>>> that get > >>>> added to the dspace.cfg during the mvn build process. > >>>> > >>>> just to verify, you ran just 'mvn clean package' prior to the ant > >>>> build? > >>>> > >>>> -Mark > >>>> > >>>> > >>> ------------------------------------------------------------------------- > >>> This SF.net email is sponsored by: Microsoft > >>> Defy all challenges. Microsoft(R) Visual Studio 2005. > >>> http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/ > >>> _______________________________________________ > >>> DSpace-tech mailing list > >>> DSpace-tech@lists.sourceforge.net > >>> https://lists.sourceforge.net/lists/listinfo/dspace-tech > >>> > >> > >> > >> ------------------------------------------------------------------------- > >> This SF.net email is sponsored by: Microsoft > >> Defy all challenges. Microsoft(R) Visual Studio 2005. > >> http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/ > >> __________________________________ > > > > > > ------------------------------------------------------------------------- > > This SF.net email is sponsored by: Microsoft > > Defy all challenges. Microsoft(R) Visual Studio 2005. > > http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/ > > _______________________________________________ > > DSpace-tech mailing list > > DSpace-tech@lists.sourceforge.net > > https://lists.sourceforge.net/lists/listinfo/dspace-tech > > > This email has been scanned by Postini. For more information please visit http://www.postini.com ------------------------------------------------------------------------- This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2005. http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/ _______________________________________________ DSpace-tech mailing list DSpace-tech@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/dspace-tech
