Thanks Peter,
The patching process went smoothly aside from like you mentioned spacing
issues in the structural.xsl file. After the patch was applied and I
made the edits to our page-structure.xsl, I tried to rebuild dspace.
The build was going well until it hit this error:
[ERROR] BUILD FAILURE
[INFO]
------------------------------------------------------------------------
[INFO] Compilation failure
/dspace/svn/dspace-xmlui/dspace-xmlui-api/src/main/java/org/dspace/app/xmlui/aspect/browseArtifacts/StaticPage.java:[31,16]
addBody(org.dspace.app.xmlui.wing.element.Body) in
org.dspace.app.xmlui.aspect.browseArtifacts.StaticPage cannot implement
addBody(org.dspace.app.xmlui.wing.element.Body) in
org.dspace.app.xmlui.cocoon.DSpaceTransformer; overridden method does
not throw org.apache.cocoon.ProcessingException
Any ideas?
-Brett
On 12/16/11 2:08 PM, Peter Dietz wrote:
Hi Brett,
Thanks for your interest in this patch. I was hoping to get more
feedback before it went in to 1.8.1, but I could have written the
patch sooner.
For the components that DS-1076 (Xmlui static pages) affects, it
should work just fine with 1.7.2. So feel free to invest the time
patching your system, it should work out. (I don't know how cleanly
the patch will apply, i.e. line space differences, but the code will
eventually work).
The main difference that prompted the DS-1076 improvement, was the new
PageNotFound improvements in 1.8, so this patch is a somewhat proper
way to do an "improper" task. Proper meaning pages in DSpace are
created by Java, that produce DRI, improper meaning that the XSL
hijacks the page and draws something different on the screen.
But during your testing, feel free to give feedback on how the process
of adding a new page goes. i.e. too annoying to edit structural.xsl
and add the title, trail, body... etc
Peter Dietz
On Fri, Dec 16, 2011 at 1:35 PM, Brett Arno <barno...@gmail.com
<mailto:barno...@gmail.com>> wrote:
I've been following the topic of static pages and them being broken in
1.8. We are currently using 1.7.2 with Mirage and wondering if the
patch
supplied here https://jira.duraspace.org/browse/DS-1076 would be
usable
on our version?
It's my understanding that the patch is just adding a new java
file and
adding some lines to other xsl files and should not be bias based
on the
version we are using, but I'd like to know for sure before I delve
into
the process of applying the patch. My knowledge of the changes between
1.7.2 and 1.8.0 is pretty lacking, so I'm probably missing something.
Thanks,
Brett
------------------------------------------------------------------------------
Learn Windows Azure Live! Tuesday, Dec 13, 2011
Microsoft is holding a special Learn Windows Azure training event for
developers. It will provide a great way to learn Windows Azure and
what it
provides. You can attend the event by watching it streamed LIVE
online.
Learn more at http://p.sf.net/sfu/ms-windowsazure
_______________________________________________
DSpace-tech mailing list
DSpace-tech@lists.sourceforge.net
<mailto:DSpace-tech@lists.sourceforge.net>
https://lists.sourceforge.net/lists/listinfo/dspace-tech
------------------------------------------------------------------------------
Learn Windows Azure Live! Tuesday, Dec 13, 2011
Microsoft is holding a special Learn Windows Azure training event for
developers. It will provide a great way to learn Windows Azure and what it
provides. You can attend the event by watching it streamed LIVE online.
Learn more at http://p.sf.net/sfu/ms-windowsazure
_______________________________________________
DSpace-tech mailing list
DSpace-tech@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/dspace-tech
