On Mon, Jun 8, 2009 at 11:04 AM, André Detsch<[email protected]> wrote: > Any chance to get this patch in soon? > Without the fix, we can't rmmod the module after the 6th EEH error. > > Mike Mason wrote: >> I forgot to copy this to e1000-devel when I posted it to netdev. >> >> Mike Mason >> >> -------- Original Message -------- >> Subject: [PATCH] e1000e: io_error_detected callback should return >> PCI_ERS_RESULT_DISCONNECT on permanent failure >> Date: Fri, 29 May 2009 14:16:40 -0700 >> From: Mike Mason <[email protected]> >> To: [email protected] >> >> PCI drivers that implement the io_error_detected callback >> should return PCI_ERS_RESULT_DISCONNECT if the state >> passed in is pci_channel_io_perm_failure. This state is >> not checked in many of the network drivers. >> >> This patch fixes the omission in the e1000e driver. >> >> Signed-off-by: Mike Mason <[email protected]> >> >> --- a/drivers/net/e1000e/netdev.c 2009-05-23 14:47:00.000000000 -0700 >> +++ b/drivers/net/e1000e/netdev.c 2009-05-29 13:43:24.000000000 -0700 >> @@ -4616,6 +4616,9 @@ static pci_ers_result_t e1000_io_error_d >> >> netif_device_detach(netdev); >> >> + if (state == pci_channel_io_perm_failure) >> + return PCI_ERS_RESULT_DISCONNECT; >> + >> if (netif_running(netdev)) >> e1000e_down(adapter); >> pci_disable_device(pdev); >> >> -- > -- > André Detsch > Kernel Software Engineer - Network Device Drivers > Linux Technology Center Brazil >
It should be submitted this week, sorry for the delay. -- Cheers, Jeff ------------------------------------------------------------------------------ Crystal Reports - New Free Runtime and 30 Day Trial Check out the new simplified licensing option that enables unlimited royalty-free distribution of the report engine for externally facing server and web deployment. http://p.sf.net/sfu/businessobjects _______________________________________________ E1000-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/e1000-devel
