On 12/07/2011 04:10 AM, Jesse Brandeburg wrote: > On Mon, 5 Dec 2011 17:04:09 -0800 > Michael Wang <wang...@linux.vnet.ibm.com> wrote: >> Actually, I make this change because of my last patch: >> e1000e: Avoid wrong check on TX hang >> >> And I get the suggestion from David, the mail like below. >> He want me to use true and false, not 1 and 0. >> >> I just want to keep the same style in e1000e driver, and I really wonder >> why we use 0 and 1 at first, is there some special reason? > > I read dave's mail after I had seen/replied to this. So I see the > reasoning now. > > If you could send a V2 of this patch with a slightly better > description, maybe even referring to the post where davem suggested you > make these changes. >
Ok, I will send out v2 as soon as possible. Thanks, Michael Wang > you can also CC: net...@vger.kernel.org and then the patch will be > tracked by the netdev patchwork, we will still apply it, and test then > post it, but it will have your authorship/signed off by better than > last time. :-) > > Thanks for your work on our drivers. > > Jesse ------------------------------------------------------------------------------ Cloud Services Checklist: Pricing and Packaging Optimization This white paper is intended to serve as a reference, checklist and point of discussion for anyone considering optimizing the pricing and packaging model of a cloud services business. Read Now! http://www.accelacomm.com/jaw/sfnl/114/51491232/ _______________________________________________ E1000-devel mailing list E1000-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/e1000-devel To learn more about Intel® Ethernet, visit http://communities.intel.com/community/wired
