Witold Filipczyk <[EMAIL PROTECTED]> writes:

> (b) is not acceptable.
> I chose /dev/urandom.

Okay but please add error handling and a check that fread() got
all the bytes it wanted.

E.g. on Windows, there will be neither /dev/urandom nor
/dev/prandom, and ELinks should detect this rather than proceed
with an uninitialized and perhaps not very random buffer.

I see though that encode_multipart() does not properly handle
errors from e.g. add_char_to_string() either.  Anyway, it's
better to keep the bug in one function than spread it around.

Attachment: pgpwG1c8XUekA.pgp
Description: PGP signature

_______________________________________________
elinks-dev mailing list
elinks-dev@linuxfromscratch.org
http://linuxfromscratch.org/mailman/listinfo/elinks-dev

Reply via email to