On 01/28/2012 09:50 PM, Jon Elson wrote: > I have just discovered a bug in the 2.5 hal/drivers/hal_ppmc.c driver. > There are several > optional features that are activated by options on the loadrt line. > These are the extradac="0x00" and the timestamp="0x00" options. > They appear to work separately, but when they both appear on the > same loadrt line, then the timestamp option seems to be ignored. > I detect this because the hal parameter ppmc.0.encoder.00.min-speed-estimate > is not exported if both options are requested. > > One other thing I noted is if I give an incorrect "slot code", I get an > error > mesaage saying no board is at that address for the extradac option, but > none for the timestamp option. I have > tried specifying the options in either order, same result. > > I have also noticed that if you give an incorrect slot code for the extradac > option, you get a specific error message, but an incorrect slot code > for the timestamp option gives no message, but the option is not enabled > in that case. > > If you request both extradac and extradout it gives a specific message for > that from line 637. > > I wonder if anyone would be willing to take a look at the code. I know > this will be hard to debug without a UPC board, so I hope maybe somebody > can see an obvious goof in the code.
The long if/elseif statement that begins on line 635 seems wrong to me. If need_extra_dac is true, then the following "else if" statements won't be checked, is that what you want? Shouldn't they be independent, with the need_* dependencies checked explicitly at the top? -- Sebastian Kuzminsky ------------------------------------------------------------------------------ Try before you buy = See our experts in action! The most comprehensive online learning library for Microsoft developers is just $99.99! Visual Studio, SharePoint, SQL - plus HTML5, CSS3, MVC3, Metro Style Apps, more. Free future releases when you subscribe now! http://p.sf.net/sfu/learndevnow-dev2 _______________________________________________ Emc-developers mailing list Emc-developers@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/emc-developers
