On Sun, Sep 29, 2013 at 10:21:46AM +0200, Michael Haberler wrote: [reasons to make _setup not be a static member of Interp snipped] > I think it is one of this 'this finally has to go' things in linuxcnc, and > this is the time > > what do you think?
You always see things in a grand connected way that is a little bit beyond me. Coming at it from the other direction, the apparent dependencies on a static _setup are small enough (in fact mostly or entirely due to the new Python integration code!) that I don't see a reason to retain it. It starts to look more like a simple accidental wart left over from the initial C++ "conversion"... (it would have been needed when not everything was converted to a method, I think, and then you just forget to remove the unneeded 'static') If the fix ends up grotesquely ugly or leads to unexpected consequences we might have to re-ask this question but for now it looks like getting rid of static _setup is more like a low-hanging fruit than a long-term project, and so probably fine for master even at this late stage. Jeff ------------------------------------------------------------------------------ October Webinars: Code for Performance Free Intel webinars can help you accelerate application performance. Explore tips for MPI, OpenMP, advanced profiling, and more. Get the most from the latest Intel processors and coprocessors. See abstracts and register > http://pubads.g.doubleclick.net/gampad/clk?id=60133471&iu=/4140/ostg.clktrk _______________________________________________ Emc-developers mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/emc-developers
