> From: [email protected] > To: [email protected] > Date: Wed, 25 Sep 2013 07:33:17 +0000 > Subject: Re: [Emc-developers] DISCUSS: feed override affects rapids > > > > > Having a separate rapid override allows one to set feed to 100% > > > and the rapid to 10% while proving a program. > > > This allows you to sneak up to the part while still cutting at the > > > proper > > > rate. > > > You can do this with max velocity but if you really want to creep > > > in rapid, you must turn the max velocity back up to feed at a proper > > > rate. As I said IMHO this behaviour is not terrible, but separate is > > > better. > >
As I heard no negative responses I continued my work.
Here is a proposed patch.
This patch makes rapid moves ignore feed override settings.
It still follows max velocity override.
I would love it if a developer familiar with the trajectory planner and tc.c
would look at it to see if the code looks fine (it's pretty simple) and if that
is the appropriated place for the change.
I will do some more testing before I am ready to push.
Thanks
Chris M
diff --git a/src/emc/kinematics/tc.c b/src/emc/kinematics/tc.c
index 61a35c3..c6866d8 100644
--- a/src/emc/kinematics/tc.c
+++ b/src/emc/kinematics/tc.c
@@ -22,6 +22,7 @@
#include "posemath.h"
#include "emcpos.h"
#include "tc.h"
+#include "motion_types.h"
PmCartesian tcGetStartingUnitVector(TC_STRUCT *tc) {
PmCartesian v;
@@ -111,6 +112,8 @@ EmcPose tcGetPosReal(TC_STRUCT * tc, int of_endpoint)
abc.tran = tc->coords.rigidtap.abc;
uvw.tran = tc->coords.rigidtap.uvw;
} else if (tc->motion_type == TC_LINEAR) {
+ // if this is rapid don't use feed override settings (max velocity
override still honoured)
+ if(tc->canon_motion_type==EMC_MOTION_TYPE_TRAVERSE) {tc->feed_override
= 1.0;}
if (tc->coords.line.xyz.tmag > 0.) {
// progress is along xyz, so uvw and abc move proportionally in
order
// to end at the same time.
--
1.7.0.4
rapid_override_fix.patch
Description: Binary data
------------------------------------------------------------------------------ October Webinars: Code for Performance Free Intel webinars can help you accelerate application performance. Explore tips for MPI, OpenMP, advanced profiling, and more. Get the most from the latest Intel processors and coprocessors. See abstracts and register > http://pubads.g.doubleclick.net/gampad/clk?id=60133471&iu=/4140/ostg.clktrk
_______________________________________________ Emc-developers mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/emc-developers
