Alon Bar-Lev has posted comments on this change. Change subject: packaging: sync miniyum with otopi ......................................................................
Patch Set 1: (1 inline comment) .................................................... File packaging/fedora/setup/miniyum.py Line 447: @property Line 448: def sink(self): Line 449: return self._sink Line 450: Line 451: def __init__( This is a question of standards, I prefer the class to list the private methods first then the public methods... and as constructor is public it is here... Line 452: self, Line 453: sink=None, Line 454: blockStdHandles=True, Line 455: extraLog=None, -- To view, visit http://gerrit.ovirt.org/10725 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ife4f8b5fe4c683b936c00d233bf18ad7d377f07a Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Alex Lourie <alou...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Moran Goldboim <mgold...@redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschr...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
