Alon Bar-Lev has posted comments on this change.
Change subject: packaging: engine-setup - add firewalld support
......................................................................
Patch Set 8: (3 inline comments)
Not too complex... :))
....................................................
File packaging/fedora/setup/basedefs.py
Line 127
Line 128
Line 129
Line 130
Line 131
Should not be in this patch.
....................................................
File packaging/fedora/setup/engine-setup.py
Line 902: _configIptables()
Line 903: else:
Line 904: # Call configIptables in any case.
Line 905: # This way, a sample configuration is available in any case
Line 906: _configIptables()
Any option of none? I don't follow why this is required.
Line 907:
Line 908: def _configFirewalld():
Line 909: logging.debug("configuring firewalld")
Line 910:
Line 989:
Line 990: with open(basedefs.FILE_IPTABLES_EXAMPLE, "w") as f:
Line 991: f.write(outputText)
Line 992:
Line 993: if not
utils.compareStrIgnoreCase(controller.CONF["OVERRIDE_FIREWALL"], "none"):
Maybe I fail to understand the flow, but I don't think the none should be
tested here.
Line 994: if
os.path.isfile("%s/iptables"%(basedefs.DIR_ETC_SYSCONFIG)):
Line 995: backupFile =
"%s.%s_%s"%(basedefs.FILE_IPTABLES_BACKUP, time.strftime("%H%M%S-%m%d%Y"),
os.getpid())
Line 996:
utils.copyFile("%s/iptables"%(basedefs.DIR_ETC_SYSCONFIG), backupFile)
Line 997:
controller.MESSAGES.append(output_messages.INFO_IPTABLES_BACKUP_FILE%(backupFile))
--
To view, visit http://gerrit.ovirt.org/10493
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ieea93c90ffb90e02b880949a67575495aac5a472
Gerrit-PatchSet: 8
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ofer Schreiber <oschr...@redhat.com>
Gerrit-Reviewer: Alex Lourie <alou...@redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com>
Gerrit-Reviewer: Moran Goldboim <mgold...@redhat.com>
Gerrit-Reviewer: Ofer Schreiber <oschr...@redhat.com>
Gerrit-Reviewer: Ohad Basan <oba...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
