Ofer Schreiber has posted comments on this change.

Change subject: packaging: branding cleanup
......................................................................


Patch Set 1: (1 inline comment)

....................................................
File packaging/fedora/spec/ovirt-engine.spec.in
Line 524:     rm -rf "%{engine_pki}"
Line 525: 
Line 526:     if [[ -f %{_sysconfdir}/yum/pluginconf.d/versionlock.list ]]
Line 527:     then
Line 528:         sed -i '/%{name}/d' 
%{_sysconfdir}/yum/pluginconf.d/versionlock.list
Actually, this might be problematic.
What will happen to files in versionlock, prefixed only with 'ovirt' and not 
'ovirt-engine'?
Line 529:     fi
Line 530: fi
Line 531: 
Line 532: 


--
To view, visit http://gerrit.ovirt.org/11000
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I62e31f8a50f7e1db575e9bd5f5388d4c60e5c34a
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Alex Lourie <alou...@redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com>
Gerrit-Reviewer: Moran Goldboim <mgold...@redhat.com>
Gerrit-Reviewer: Ofer Schreiber <oschr...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to