Alon Bar-Lev has posted comments on this change. Change subject: build: build rewrite using autotools ......................................................................
Patch Set 5: (3 inline comments) .................................................... File src/ovf/Makefile.am Line 20: MAINTAINERCLEANFILES = \ Line 21: $(srcdir)/Makefile.in \ Line 22: $(NULL) Line 23: Line 24: EXTRA_DIST = \ still waiting... should we install these somewhere? Line 25: CIM_ResourceAllocationSettingData.xsd \ Line 26: CIM_VirtualSystemSettingData.xsd \ Line 27: common.xsd \ Line 28: ovf-environment.xsd \ Line 29: ovf-envelope.xsd \ Line 30: sample-ovf.xml \ Line 31: $(NULL) Line 32: Line 33: ovfdir=$(ovirtimageuploaderlibdir)/ovf Is this location correct? Line 34: dist_ovf_PYTHON = \ Line 35: __init__.py \ Line 36: ovfenvelope.py \ Line 37: ovfenvelopetest.py \ Line 30: sample-ovf.xml \ Line 31: $(NULL) Line 32: Line 33: ovfdir=$(ovirtimageuploaderlibdir)/ovf Line 34: dist_ovf_PYTHON = \ Should we install these? Line 35: __init__.py \ Line 36: ovfenvelope.py \ Line 37: ovfenvelopetest.py \ Line 38: $(NULL) -- To view, visit http://gerrit.ovirt.org/11145 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If2dabcd40a50e9ec19e796832d83fb9e89d5db24 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-image-uploader Gerrit-Branch: master Gerrit-Owner: Kiril Nesenko <knese...@redhat.com> Gerrit-Reviewer: Alex Lourie <alou...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Keith Robertson <krobe...@redhat.com> Gerrit-Reviewer: Kiril Nesenko <knese...@redhat.com> Gerrit-Reviewer: Moran Goldboim <mgold...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
