Itamar Heim has posted comments on this change.

Change subject: packaging: Starting ssh before adding host in AIO
......................................................................


Patch Set 1: (1 inline comment)

....................................................
File packaging/fedora/setup/plugins/all_in_one_100.py
Line 258: def createHost():
Line 259:     global controller
Line 260:     logging.debug("Adding the local host")
Line 261:     try:
Line 262:         sshd = utils.Service("sshd")
I think a warning is required for starting such a service for the user (good 
thing we don't need it up after we finish installation/reboot).
"The SSHD service is required to install the local host [start]"
Line 263:         if sshd.available():
Line 264:             sshd.autoStart()
Line 265:             sshd.start()
Line 266:         else:


--
To view, visit http://gerrit.ovirt.org/11155
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I84cbacec81d08cc72d8951887b5ad44c3c2cb4fa
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alex Lourie <alou...@redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Itamar Heim <ih...@redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com>
Gerrit-Reviewer: Moran Goldboim <mgold...@redhat.com>
Gerrit-Reviewer: Ofer Schreiber <oschr...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to