[Engine-patches] Change in ovirt-engine[master]: gluster: Fetch brick statuses only for UP volumes

[sanjal]

Shireesh Anjal has uploaded a new change for review.

Change subject: gluster: Fetch brick statuses only for UP volumes
......................................................................

gluster: Fetch brick statuses only for UP volumes

Brick statuses are fetched by executing the gluster cli command
'gluster volume status' which works only on UP volumes. Hence
we should not try to fetch and update brick statuses for volumes
that are currently DOWN.

Change-Id: If7f28948036993423d5baad2f4af41875670a18a
Signed-off-by: Shireesh Anjal <san...@redhat.com>
---
M 
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterManager.java
1 file changed, 14 insertions(+), 11 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/56/11156/1

diff --git 
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterManager.java
 
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterManager.java
index c9bda3b..b35ccfc 100644
--- 
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterManager.java
+++ 
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterManager.java
@@ -807,12 +807,14 @@
         log.debug("Refreshing Gluster Data [heavyweight]");
 
         for (VDSGroup cluster : getClusterDao().getAll()) {
-            try {
-                refreshClusterHeavyWeightData(cluster);
-            } catch (Exception e) {
-                log.errorFormat("Error while refreshing Gluster heavyweight 
data of cluster {0}!",
-                        cluster.getname(),
-                        e);
+            if (cluster.supportsGlusterService()) {
+                try {
+                    refreshClusterHeavyWeightData(cluster);
+                } catch (Exception e) {
+                    log.errorFormat("Error while refreshing Gluster 
heavyweight data of cluster {0}!",
+                            cluster.getname(),
+                            e);
+                }
             }
         }
     }
@@ -824,11 +826,12 @@
             return;
         }
 
-        if (cluster.supportsGlusterService()) {
-            for (GlusterVolumeEntity volume : 
getVolumeDao().getByClusterId(cluster.getId())) {
-                log.debugFormat("Refreshing brick statuses for volume {0} of 
cluster {1}",
-                        volume.getName(),
-                        cluster.getname());
+        for (GlusterVolumeEntity volume : 
getVolumeDao().getByClusterId(cluster.getId())) {
+            log.debugFormat("Refreshing brick statuses for volume {0} of 
cluster {1}",
+                    volume.getName(),
+                    cluster.getname());
+            // brick statuses can be fetched only for started volumes
+            if (volume.isOnline()) {
                 acquireLock(cluster.getId());
                 try {
                     refreshBrickStatuses(upServer, volume);


--
To view, visit http://gerrit.ovirt.org/11156
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: If7f28948036993423d5baad2f4af41875670a18a
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shireesh Anjal <san...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches