Ibukun Olumuyiwa <[EMAIL PROTECTED]> [2004-08-28 01:03]: > On Fri 27 Aug 2004, Tilman Sauerbeck wrote: > > Ibukun Olumuyiwa <[EMAIL PROTECTED]> [2004-08-27 16:38]: > > > On Fri 27 Aug 2004, [EMAIL PROTECTED] wrote: > > > > Enlightenment CVS committal > > > > > > > > Author : tsauerbeck > > > > Project : e17 > > > > Module : libs/ecore > > > > > > > > Dir : e17/libs/ecore/src/lib/ecore_evas > > > > > > > > > > > > Modified Files: > > > > Ecore_Evas.h.in ecore_evas_x.c > > > > > > > > > > > > Log Message: > > > > added ecore_evas_gl_x11_window_get() > > > > > > Is this not redundant? It doesn't do anything different from > > > software_x11_window_get() as far as I can see. Feels like unneeded bloat. > > > > Yes, but the function name clearly indicates that its specific to the > > engine that's used so it makes sense to have an extra function for the > > GLX11 engine. > > > > So why not rename the function to ecore_evas_x11_window_get() or something > similar? I know it's massive api breakage, but it should be trivially easy > to fix throughout CVS. I guess I just don't fancy the idea of having two > different functions in the same file that do the exact same thing.
Hehe. Could do this. Although with the current naming its really obvious that they only work for a particular engine (same prefix). And who knows whether the functions will always have the same functionality. That's my reasoning here, does anyone else have an opinion on his? :) > -- > > Ibukun Olumuyiwa > http://xcomputerman.com > > "God is dead." - Nietzche > "Nietzche is dead." - God It's "Nietzsche" ;) -- Regards, Tilman ------------------------------------------------------- This SF.Net email is sponsored by BEA Weblogic Workshop FREE Java Enterprise J2EE developer tools! Get your free copy of BEA WebLogic Workshop 8.1 today. http://ads.osdn.com/?ad_id=5047&alloc_id=10808&op=click _______________________________________________ enlightenment-devel mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
