Ravenlock wrote: > On 02/24/2007 23:05, Ravenlock wrote: >> On 02/24/2007 17:27, Sebastian Dransfeld wrote: >>> If pinned is actually just a combination of three other states, why >>> not just make an action which triggers these states and not add a lot >>> of duplicate code? >>> >>> Sebastian >> >> [Sorry if this double posts. Sent originally from wrong e-mail address] >> >> Attached is a modified patch which addresses Sebastian's concerns (I >> hope). >> >> Thanks for pointing it out. :) >> > > OK. Per discussions on irc... I have attempted to address some concerns. > > - I cleaned up the code a tad. > - removed the pinned_to_desktop state of the border. > - No config panel changes whatsoever > > I have attached two patches. One that does the above, and a second > which will add an action to the keybindings dialog to allow a user to > create a binding to toggle the... uh... no longer existing state. Well, > again, it just seems convenient. I realize this may not be desired, > hence the separate patch. > > The 'cleanup' patch is more on the necessary side. The action is just > for convenience (as are most actions I think). > > -Ravenlock > >>> >>> Ravenlock wrote: >>>> Hello, >>>> >>>> Attached is a patch which will allow a user to have borders remember >>>> their pinned state. Additionally, an action has been added to the >>>> keybindings that allows a user to toggle this state via the keyboard. >>>> >>>> >>> >>> Both put into cvs :) I fixed some minor formatting in your patches and also a bunch of formatting in e_actions.c while I was there :)
Cheers, dh ------------------------------------------------------------------------- Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT & business topics through brief surveys-and earn cash http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV _______________________________________________ enlightenment-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
