On Fri, 15 Feb 2008 23:54:16 +0100 (CET) Vincent Torri <[EMAIL PROTECTED]> babbled:
ok- that looks a lot cleaner after the diff. other than the EAPI removal in .c files. i'd agree on making an EAPI_DEF for the .c files (just sed s/EAPI EAPI_DEF for all .c files) and for win32 just making that empty to keep it happy. otherwise it seems its just autofoo additions to detect etc. i say do it (with the above change)? > Hey, > > as the Windows Mobile platform is trying to be supported, a lot of #ifdef > might appear. So I began to move the win32 code from the efl to a single > lib (named 'evil'). The source code for that lib is attached, for those > who are interested. Currently, the main functions that are ported are dl* > functions, mmap and munmap, and fcntl. > > There is also a patch for eet that is attached. It shows the modifications > in eet when 'evil' is used. It's not so evil, finally :) > > Another thing I've discovered is how libtool manages the export of the > functions on Windows. Everything is done with EAPI with a small > modification. But, contrary to gcc on linux, which does not complain when > EAPI is used on declaration and definition of the functions, on Windows > there is an error. So I have to define to nothing EAPI on Windows. I added > that in eet_lib.c, eet_data.c and eet_image.c. > > I can also add it in Eet_private.h, but I have to include Eet_private.h > after Eet.h. > > Another solution would be to remove EAPI on definitions of the exported > functions (it's sufficient to have it on declarations). But raster prefers > to keep them as it shows which functions are really exported in the .c > files. I think that it can be replaced by organising the files like that: > > static declarations and non exported functions > definitions of exported functions > definitions of non exported functions > definitions of static functions > > and by adding good comments. > > It's easy to manage EAPI with eet. I let you imagine with a beast like > evas (I have the diff somewhere. It's quite ugly) > > comments, ideas are welcome. > > Vincent -- ------------- Codito, ergo sum - "I code, therefore I am" -------------- The Rasterman (Carsten Haitzler) [EMAIL PROTECTED] ------------------------------------------------------------------------- This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2008. http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/ _______________________________________________ enlightenment-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
