On Mon, 12 Oct 2009, Marc Andre Tanner wrote:

> On Sun, Oct 11, 2009 at 11:43:50PM +0200, Vincent Torri wrote:
>>
>>
>> On Sun, 11 Oct 2009, Marc Andre Tanner wrote:
>>
>>> This makes ecore-file useable without ecore-con.
>>
>> better one : http://pastebin.ca/1613582
>
> Why do you think this one is better? It clutters the source with more
> #ifdef's and if you add a new function you will have to remember to
> add the check for BUILD_ECORE_CON.

because you removed API functions, which must exist, ecore_con installed 
or not.

>
> Anyway whoever maintains the code should decide which solution he
> prefers.

no decision, here. the API functions must be available.

>> is it working for you ?
>
> No, it breaks the build on the first use of EAPI which is probably
> undefined because you moved the first #ifdef before the inclusion
> of ecore_file_private.h

indeed. And moving it just after the inclusion of the headers.

Vincent

------------------------------------------------------------------------------
Come build with us! The BlackBerry(R) Developer Conference in SF, CA
is the only developer event you need to attend this year. Jumpstart your
developing skills, take BlackBerry mobile applications to market and stay 
ahead of the curve. Join us from November 9 - 12, 2009. Register now!
http://p.sf.net/sfu/devconference
_______________________________________________
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Reply via email to