On Thu, Dec 9, 2010 at 4:30 AM, ChunEon Park <chuneon.p...@samsung.com> wrote: > Here is new elm_transit patch . > > Fixed indentation and fixed some logic of flip/resizableflip/wipe effect.
Hi, As Mike said, don't mix whitespaces, bug fixes and refactories in the same patch. Yes, Raster is a very bad example and does this, but he needs to be fixed and we're not taking the patches like that. >From your patch it looks like it should be 3: - whitespaces cleanup; - fix to tween_mode; - rename of event_block. If you wish to reorder the bitfields to last, you can make another one. To aid this boring task, just use git: cd elementary; git init git add . git commit -m "init" $EDITOR src/lib/elm_transit.c src/lib/Elementary.h.in git commit src/lib/elm_transit.c src/lib/Elementary.h.in -m "whitespace cleanup" $EDITOR src/lib/elm_transit.c src/lib/Elementary.h.in git commit src/lib/elm_transit.c src/lib/Elementary.h.in -m "Fixes to tween mode" $EDITOR src/lib/elm_transit.c src/lib/Elementary.h.in git commit src/lib/elm_transit.c src/lib/Elementary.h.in -m "Rename elm_transit_event_block_* to elm_transit_event_enabled_* as per mail list agreement" git format-patch -3 rm -fr .git then you mail 000*-*.patch and we can apply with our scripts http://barbieri-playground.googlecode.com/svn/python/svn-git-am.py with a single command, it will keep your commit message and even your GIT_AUTHOR name/email, the SVN history will be clear about your changes, etc. I hope you understand it's not to make it harder to you to contribute, but to make it harder to check out the history in future and to allow patches to be easily checked by those that read the commit logs. One technical note: do we need to keep the symbol elm_transit_event_block_set()? Couldn't it be a macro? elm_transit is very new and code shouldn't be relying on it. If nothing is using it we can even remove the function altogether. -- Gustavo Sverzut Barbieri http://profusion.mobi embedded systems -------------------------------------- MSN: barbi...@gmail.com Skype: gsbarbieri Mobile: +55 (19) 9225-2202 ------------------------------------------------------------------------------ This SF Dev2Dev email is sponsored by: WikiLeaks The End of the Free Internet http://p.sf.net/sfu/therealnews-com _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
