On Thu, 6 Apr 2017 14:07:53 -0700 Thomas Guilbert <tguilb...@chromium.org> wrote:
> The patch didn't show up as properly formatted on > https://patchwork.ffmpeg.org/patch/3228/. > > Re-submitting using no line wrap in the base64 attachment, and copying the > contents of the patch for ease of review: > > From fced5ab0e09f529397adddcb560d1a08f2df4840 Mon Sep 17 00:00:00 2001 > From: Thomas Guilbert <tguilb...@chromium.org> > Date: Thu, 30 Mar 2017 18:23:29 -0700 > Subject: [PATCH] Fix dictionnary leak in mp3dec > > --- > libavformat/mp3dec.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/libavformat/mp3dec.c b/libavformat/mp3dec.c > index 0924a57843..fd8184cc0b 100644 > --- a/libavformat/mp3dec.c > +++ b/libavformat/mp3dec.c > @@ -349,6 +349,7 @@ static int mp3_read_header(AVFormatContext *s) > int ret; > int i; > > + av_dict_free(&s->metadata); > s->metadata = s->internal->id3v2_meta; > s->internal->id3v2_meta = NULL; > So in which situations is s->metadata not NULL? _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel