> I've noticed something related in reviews over the years, though. Some- > times when reviewers give a lot of comments on Gerrit, among them some > critical ones about the overall patch and a lot of nits, the author > tends to fix the nits and ignore the critical comments. Sure, when > somebody ignores comments and then things get reverted, it's techni- > cally their fault. But I can well imagine that such incidents would > affect future reviews, also for the reviewers. Somehow, everybody > learned that they wasted their time :-/
In formal software engineering culture, there is a notion of findings being major vs minor, where major is failure to meet specification and minor is something else, usually style. I think the basic issue is that flashrom, quite reasonably, is trying to achieve a far higher level of software quality than is typical in open source. It might be reasonable to expect that after a review which had a major finding, to expect it to be re-reviewed before merging.
signature.asc
Description: PGP signature
_______________________________________________ flashrom mailing list -- flashrom@flashrom.org To unsubscribe send an email to flashrom-le...@flashrom.org
