* [EMAIL PROTECTED] (Curtis L. Olson) [2002.03.21 08:58]:
> Index: panel_io.cxx
> ===================================================================
> RCS file: /var/cvs/FlightGear-0.7/FlightGear/src/Cockpit/panel_io.cxx,v
> retrieving revision 1.36
> retrieving revision 1.37
> diff -C2 -r1.36 -r1.37
> *** panel_io.cxx      19 Mar 2002 16:12:15 -0000      1.36
> --- panel_io.cxx      20 Mar 2002 14:57:31 -0000      1.37
> ***************
> *** 296,300 ****
>     }
>   
> !   if (propName != "") {
>       target = fgGetNode(propName.c_str(), true);
>     }
> --- 296,300 ----
>     }
>   
> !   if (propName != (string)"") {
>       target = fgGetNode(propName.c_str(), true);
>     }

As Bernie has mentioned before[1], this should be:

  if (!propName.empty()) {

And for someone who has time, there's plenty more of these to be fixed:

$ cd FlightGear/src/
$ find . -type f -name '*.[ch]??' | xargs grep -n '[=!]= ""'
./ATC/ATCmgr.cxx:112:     if(last_comm1_ident != "") {
./FDM/JSBSim/FGConfigFile.cpp:129:  if (val == "") {    // this call is to return the 
tag value
./FDM/JSBSim/FGScript.cpp:190:  if (aircraft == "") {
./Cockpit/panel.cxx:1079:  if (_fmt == "") 
./Cockpit/panel.cxx:1087:  if (_fmt == "") {
./Cockpit/panel_io.cxx:291:  if (type == "") {
./Cockpit/panel_io.cxx:393:  if (type == "") {
./Cockpit/panel_io.cxx:468:  if (type == "") {
./Cockpit/panel_io.cxx:551:    else if (layerclass == "") {
./Cockpit/panel_io.cxx:718:  if (bgTexture == "")
./Cockpit/panel_io.cxx:732:    if (mbgTexture == "")
./Cockpit/panel_io.cxx:738:    if (mbgTexture == "")
./Cockpit/panel_io.cxx:744:    if (mbgTexture == "")
./Cockpit/panel_io.cxx:750:    if (mbgTexture == "")
./Cockpit/panel_io.cxx:756:    if (mbgTexture == "")
./Cockpit/panel_io.cxx:762:    if (mbgTexture == "")
./Cockpit/panel_io.cxx:768:    if (mbgTexture == "")
./Input/input.cxx:113:  if (_command_name == "") {
./Main/fg_init.cxx:143:    if ( root == "" ) {
./Main/fg_init.cxx:158:    if ( root == "" ) {
./Main/fg_init.cxx:168:    if ( root == "" ) {
./Main/fg_init.cxx:177:    if ( root == "" ) {
./Main/fg_props.cxx:145:  if (classes == "" || classes == "all") { // default
./Main/fg_props.cxx:203:  } else if (priority == "" || priority == "info") { // default
./Navaids/fixlist.cxx:106:    if ( fix->get_ident() == "" ) {
./Network/props.cxx:206:  if ( ttt == "" ) {
./Network/props.cxx:272:  if ( prompt == "" ) {
./Sound/fg_fx.cxx:56:   if (path_str == "") {

$ find . -type f -name '*.[ch]??' | xargs grep -n '[=!]= (string)""'
./src/Cockpit/panel_io.cxx:298:  if (propName != (string)"") {
./src/Cockpit/panel_io.cxx:727:  if (mbgTexture != (string)"") {
./src/GUI/gui.cxx:170:    if (throwable.getOrigin() != (string)"") {
./src/Main/fg_props.cxx:108:      if (result != (string)"")
./src/Scenery/FGTileLoader.cxx:95:  if ( globals->get_fg_scenery() != (string)"" ) {
./src/Sound/soundmgr.cxx:248:    if (file == (string)"")


$ cd SimGear/simgear/
$ find . -type f -name '*.[ch]??' | xargs grep -n '[=!]= ""'
./io/sg_socket.cxx:192:    if ( port_str == "" || port_str == "any" ) {
./io/sg_socket_udp.cxx:59:    if ( port_str == "" || port_str == "any" ) {
./misc/props.cxx:274:  else if (components[position].name == "") {

$ find . -type f -name '*.[ch]??' | xargs grep -n '[=!]= (string)""'
./misc/exception.cxx:89:  if (_path != (string)"") {
./timing/sg_time.cxx:91:    if ( root != (string)"" ) {

[1] http://mail.flightgear.org/pipermail/flightgear-cvslogs/2002-March/001102.html
-- 
Cameron Moore
[ If a mute kid swears, should his mother wash his hands with soap? ]

_______________________________________________
Flightgear-devel mailing list
[EMAIL PROTECTED]
http://mail.flightgear.org/mailman/listinfo/flightgear-devel

Reply via email to