* John Denker -- Friday 02 March 2007:
> On 03/01/2007 02:19 PM, AJ MacLeod wrote:
> > Was the stuff at line 300 intended to be in there?
>
> Actually yes, I put the call-trace in there for a reason, and I left
> it in there for a reason.
OK. Please remove it. Things like these have no place in the source code:
void FGATCDialog::Init() {
+#if 0
+Called from:
+:#1 0x080e8128 in FGATCDialog::Init (this=0xb375a10) at ATCDialog.cxx:104
+:#2 0x080aedd4 in FGATCMgr::init (this=0xb370748) at ATCmgr.cxx:150
+:#3 0x0807aec6 in fgInitSubsystems () at fg_init.cxx:1698
+:#4 0x0805cc59 in fgIdleFunction () at main.cxx:869
+:#5 0x0809bce1 in GLUTidle () at fg_os.cxx:122
+:#6 0xb7ac3d3a in glutMainLoop () from /usr/lib/libglut.so.3
+:#7 0x0805bbad in fgMainInit (argc=3, argv=0xbfb6ed34) at main.cxx:1029
+#endif
// Add ATC-dialog to the command list
This is the most absurd stuff that I've seen added to a function. I'm
almost inclined to think you want to make fun of us.
hxx:
+ virtual void Init();
cxx:
+void FGATC::Init() {
+// This should never be called, since each derived class will have its own
+// Init() that overrides this one.
+}
So, why are you adding it?!
atis.cxx is *exclusively* tab indented. Please respect that, and don't
replace tabs (8 positions) with two spaces. Applying this patch would
mess up the whole file.
Don't use cout/cerr. Use SG_LOG with appropriate log levels.
This is not a complete review -- I stopped reading when I came to the
badly structured compact code blocks.
m.
-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys-and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
Flightgear-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/flightgear-devel
